Skip to content

replace prom2json with native Prometheus parser and context-aware scraping in CLI metrics #3932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mmetc merged 3 commits into from
Nov 21, 2025
Merged

replace prom2json with native Prometheus parser and context-aware scraping in CLI metrics #3932

mmetc merged 3 commits into from
Nov 21, 2025

Conversation

@mmetc
Copy link
Contributor

@mmetc mmetc commented Sep 30, 2025

No description provided.

@mmetc mmetc added the dependencies Pull requests that update a dependency file label Sep 30, 2025
@github-actions
Copy link

github-actions bot commented Sep 30, 2025

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

github-actions bot commented Sep 30, 2025

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added kind/dependencies and removed dependencies Pull requests that update a dependency file labels Sep 30, 2025
@mmetc mmetc mentioned this pull request Sep 30, 2025
Closed
@codecov
Copy link

codecov bot commented Sep 30, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 36.26943% with 123 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.66%. Comparing base (09a1ed1) to head (f31148a).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
cmd/crowdsec-cli/cliitem/metrics.go 11.11% 64 Missing ⚠️
cmd/crowdsec-cli/climetrics/store.go 37.97% 48 Missing and 1 partial ⚠️
cmd/crowdsec-cli/climetrics/scrape.go 79.48% 5 Missing and 3 partials ⚠️
cmd/crowdsec-cli/cliitem/cmdinspect.go 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3932      +/-   ##
==========================================
+ Coverage   62.62%   62.66%   +0.03%     
==========================================
  Files         456      457       +1     
  Lines       33076    33021      -55     
==========================================
- Hits        20715    20692      -23     
+ Misses      10240    10206      -34     
- Partials     2121     2123       +2
Flag Coverage Δ
bats 46.26% <36.26%> (-0.05%) ⬇️
unit-linux 35.34% <0.00%> (+0.06%) ⬆️
unit-windows 24.72% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmetc mmetc changed the title deps: update prometheus client deps: update prometheus client, drop prom2json Sep 30, 2025
@mmetc mmetc added this to the 1.7.2 milestone Sep 30, 2025
@mmetc mmetc marked this pull request as draft September 30, 2025 13:23
@mmetc mmetc marked this pull request as ready for review September 30, 2025 14:23
@mmetc mmetc changed the title deps: update prometheus client, drop prom2json Replace prom2json with native Prometheus parser and context-aware scraping in CLI metrics Oct 6, 2025
@mmetc mmetc changed the title Replace prom2json with native Prometheus parser and context-aware scraping in CLI metrics replace prom2json with native Prometheus parser and context-aware scraping in CLI metrics Oct 6, 2025
@mmetc mmetc modified the milestones: 1.7.2, 1.7.3, 1.7.4 Oct 20, 2025
@mmetc mmetc merged commit 6a73994 into master Nov 21, 2025
16 checks passed
@mmetc mmetc deleted the dep-prometheus branch November 21, 2025 12:17
mmetc added a commit that referenced this pull request Nov 24, 2025
@mmetc
replace prom2json with native Prometheus parser and context-aware sc…
2faa0a0 
…raping in CLI metrics (#3932)

* deps: update prometheus client

* remove dependency on prom2json

* lint: protogetter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blotus blotus blotus approved these changes

Assignees

No one assigned

Labels

kind/dependencies needs/area triage/accepted

Projects

None yet

Milestone

1.7.4

Development

Successfully merging this pull request may close these issues.

3 participants

@mmetc @blotus