Add option to set enroll key via file for Docker swarm secrets #3939
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Docker in swarm mode, the use of environmental variables for secrets is discouraged. Instead, swarm secrets are the way how sensitive data is managed: https://docs.docker.com/engine/swarm/secrets/
With swarm secrets, it is by design impossible to mount them as environment variables. Swarm secrets will be mounted as a file, containing the secret's value. To tackle this issue, it is common practice to add another configuration option for Docker images as environment variable, ususally called
VAR_NAME_FILEfor a environment variableVAR_NAME, that will instead point to a file containing the sensitive configuration value.A popular example of this would be https://hub.docker.com/_/postgres#docker-secrets.
This pull requests adds a new environment variable
ENROLL_KEY_FILEin addition to the already existingENROLL_KEY, allowing to pass an enroll key in swarm setup using swarm secrets.I am aware, that the crowdsec image does already support swarm secrets for bouncer API keys, however, I feel like the mechanics differ from what is preferable for the enroll key.