Skip to content

chore: update hardcodeded hashes following cryspen/hax#1559 #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 6, 2025
Merged

chore: update hardcodeded hashes following cryspen/hax#1559 #1136

merged 3 commits into from
Oct 6, 2025

Conversation

@W95Psp
Copy link
Member

@W95Psp W95Psp commented Sep 9, 2025

Companion PR of cryspen/hax#1559.

This PR updates the hardcoded hashes for implementation expressions we have as inline F* in the code.

@W95Psp W95Psp requested a review from a team as a code owner September 9, 2025 13:47
@W95Psp W95Psp mentioned this pull request Sep 9, 2025
Merged
@W95Psp W95Psp marked this pull request as draft September 9, 2025 14:30
@W95Psp
Copy link
Member Author

W95Psp commented Sep 9, 2025 •
edited
Loading

This must be merged when (1) hax will be released and (2) hax-lib will be updated in libcrux.
Until then, it cannot be merged.
Thus, putting this back as a draft.

The next release is scheduled early Nov.

@franziskuskiefer franziskuskiefer added the do-not-merge Don't merge this PR label Sep 9, 2025
@franziskuskiefer franziskuskiefer removed the request for review from jschneider-bensch September 9, 2025 15:29
@maximebuyse
Copy link
Contributor

This must be merged when (1) hax will be released and (2) hax-lib will be updated in libcrux. Until then, it cannot be merged. Thus, putting this back as a draft.

The next release is scheduled early Nov.

Hax 0.3.5 is now released, I pushed a commit in this PR to make the upgrade for libcrux. If CI succeeds we can probably merge.

@maximebuyse maximebuyse marked this pull request as ready for review October 2, 2025 13:07
@maximebuyse maximebuyse requested a review from a team as a code owner October 2, 2025 13:07
@maximebuyse maximebuyse removed the do-not-merge Don't merge this PR label Oct 2, 2025
karthikbhargavan
karthikbhargavan approved these changes Oct 6, 2025
View reviewed changes
Copy link
Contributor

@karthikbhargavan karthikbhargavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@karthikbhargavan karthikbhargavan added this pull request to the merge queue Oct 6, 2025
Merged via the queue into main with commit 091eac3 Oct 6, 2025
101 checks passed
@karthikbhargavan karthikbhargavan deleted the frontend-upgrades-hash-fixes branch October 6, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

@karthikbhargavan karthikbhargavan karthikbhargavan approved these changes

Assignees

@W95Psp W95Psp

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@W95Psp @maximebuyse @franziskuskiefer @karthikbhargavan