Skip to content

Conversation

@wysiwys
Copy link
Contributor

@wysiwys wysiwys commented Nov 17, 2025

  • Implement key-centric and slice-based signature public APIs for libcrux-ml-dsa, libcrux-ed25519, and libcrux-ecdsa
  • Include macros in libcrux-traits crate that reduce boilerplate in signature API implementations in crates
  • Add libcrux-signature crate
  • Implement internal sign_mut() in libcrux-ml-dsa (moved from the change in Signature traits #1080 )
  • Update changelogs
  • Additional documentation as needed

Resolves #1034

@wysiwys wysiwys self-assigned this Nov 17, 2025
Copy link
Member

@keks keks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks pretty good! I left some comments for feedback. I also noticed that there are a few public items (I think just modules?) that do not have a doc comment, I guess these are what you had in mind with the documentation todo in the PR?

#[doc(inline)]
pub use arrayref::*;

// TODO: different error type?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me the error type looks good - what were you thinking of here? I suppose we could define the error somewhere else and reuse it across modules?

@franziskuskiefer franziskuskiefer mentioned this pull request Dec 1, 2025
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Signature APIs

2 participants