-
Notifications
You must be signed in to change notification settings - Fork 30
Signature APIs #1241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Signature APIs #1241
Conversation
keks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks pretty good! I left some comments for feedback. I also noticed that there are a few public items (I think just modules?) that do not have a doc comment, I guess these are what you had in mind with the documentation todo in the PR?
| #[doc(inline)] | ||
| pub use arrayref::*; | ||
|
|
||
| // TODO: different error type? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me the error type looks good - what were you thinking of here? I suppose we could define the error somewhere else and reuse it across modules?
libcrux-ml-dsa,libcrux-ed25519, andlibcrux-ecdsalibcrux-traitscrate that reduce boilerplate in signature API implementations in crateslibcrux-signaturecratesign_mut()inlibcrux-ml-dsa(moved from the change in Signature traits #1080 )Resolves #1034