Fix: wrong ErrorType parsing when a type is referenced before it's defined #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing but it doesn't look related to the change... |
RX14
approved these changes
Jan 22, 2020
This was referenced Jan 27, 2020
|
It looks like this PR fixes #57 too. |
|
Anyone else gonna review this or I'll just merge? We should work out whether we have the interest among the core team to at least review PRs for this repo. |
maxfierke
added a commit
to maxfierke/crystal_lib
that referenced
this pull request
Apr 6, 2020
Fix: wrong ErrorType parsing when a type is referenced before it's defined
|
Hey 👋 Can we consider to merge this fix now it's approved? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64
Fixes #57