-
Notifications
You must be signed in to change notification settings - Fork 4
Fix mdformat 1.0.0 compatibility #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
OK I finished all my changes. @csala, can you trigger the CI workflows so we can see the effects? |
|
Hey @kdeldycke thanks for the proposal! I agree with many of the things that you are proposing, but I would prefer not to take this huge PR in at once and rather do things one by one. Would you mind making this PR strictly about issue #17, without any of the other unrelated changes (including #18, which I would like to treat separately) |
|
Yes, no worries! As in csala/mdformat-simple-breaks#4, I'll scale down the PR and make separate proposals. Thanks for the quick answer! :) |
3741bac to
344c474
Compare
.mdformat.toml takes precedence8121b88 to
4300a2a
Compare
4300a2a to
d7d9cc0
Compare
|
@csala Just finish splitting up all changes into independent PRs. Also reduced the changes for each to their minimum. All are ready to be reviewed and merged upstream! :) |
|
Same as csala/mdformat-simple-breaks#4 , I just merged #23 on top of this one to fix the mutually dependent PRs. @csala can you triggers the workflows on this one too? |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19 +/- ##
==========================================
+ Coverage 92.50% 97.29% +4.79%
==========================================
Files 2 2
Lines 40 37 -3
==========================================
- Hits 37 36 -1
+ Misses 3 1 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
All checks passed, so merging this. Thanks @kdeldycke ! |
|
Yeah! Happy to see everything's right! Thanks for the merge! :) |
This PR closes: #18
Given the big changes, I couldn't help but try to update things left and right:
mdformat 1.0.0owns requirement)pytest >= 8.4.0(first version to support Python 3.14)Sorry if this PR feels a bit bigger in scope than simply fixing
mdformat 1.0.0compatibility. So please tell me if some changes are too aggressive in which case I'll be happy to scale down my propositions.