Skip to content

Conversation

@kdeldycke
Copy link
Contributor

@kdeldycke kdeldycke commented Oct 22, 2025

This PR closes: #18

Given the big changes, I couldn't help but try to update things left and right:

  • Bump minimal Python to 3.10 (to align it with mdformat 1.0.0 owns requirement)
  • Remove cache compatibility import for Python 3.9
  • Add tests on Python 3.14
  • Remove tests on Python 3.9
  • Bump pytest >= 8.4.0 (first version to support Python 3.14)
  • Bump CI GitHub workflow actions

Sorry if this PR feels a bit bigger in scope than simply fixing mdformat 1.0.0 compatibility. So please tell me if some changes are too aggressive in which case I'll be happy to scale down my propositions.

@kdeldycke kdeldycke marked this pull request as draft October 22, 2025 10:40
@kdeldycke kdeldycke marked this pull request as ready for review October 22, 2025 10:59
@kdeldycke
Copy link
Contributor Author

OK I finished all my changes. @csala, can you trigger the CI workflows so we can see the effects?

@csala
Copy link
Owner

csala commented Oct 23, 2025

Hey @kdeldycke thanks for the proposal!

I agree with many of the things that you are proposing, but I would prefer not to take this huge PR in at once and rather do things one by one.

Would you mind making this PR strictly about issue #17, without any of the other unrelated changes (including #18, which I would like to treat separately)

@kdeldycke
Copy link
Contributor Author

Yes, no worries! As in csala/mdformat-simple-breaks#4, I'll scale down the PR and make separate proposals. Thanks for the quick answer! :)

@kdeldycke kdeldycke force-pushed the fix-mdformat-1.0.0 branch 2 times, most recently from 3741bac to 344c474 Compare October 23, 2025 14:07
@kdeldycke kdeldycke changed the title Fix mdformat 1.0.0 compatibility and makes .mdformat.toml takes precedence Fix mdformat 1.0.0 compatibility Oct 23, 2025
@kdeldycke kdeldycke force-pushed the fix-mdformat-1.0.0 branch 2 times, most recently from 8121b88 to 4300a2a Compare October 23, 2025 14:32
@kdeldycke
Copy link
Contributor Author

@csala Just finish splitting up all changes into independent PRs. Also reduced the changes for each to their minimum. All are ready to be reviewed and merged upstream! :)

@kdeldycke
Copy link
Contributor Author

Same as csala/mdformat-simple-breaks#4 , I just merged #23 on top of this one to fix the mutually dependent PRs.

@csala can you triggers the workflows on this one too?

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.29%. Comparing base (b476b07) to head (6302a30).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   92.50%   97.29%   +4.79%     
==========================================
  Files           2        2              
  Lines          40       37       -3     
==========================================
- Hits           37       36       -1     
+ Misses          3        1       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@csala csala merged commit 93e3972 into csala:master Oct 27, 2025
13 checks passed
@csala
Copy link
Owner

csala commented Oct 27, 2025

All checks passed, so merging this. Thanks @kdeldycke !

@kdeldycke
Copy link
Contributor Author

Yeah! Happy to see everything's right! Thanks for the merge! :)

@kdeldycke kdeldycke deleted the fix-mdformat-1.0.0 branch October 27, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uncap mdformat < 1.dev0 requirement

3 participants