Skip to content

Conversation

@kdeldycke
Copy link
Contributor

This PR use simpler, ad-hoc native types.

It also defers typing in the same spirit as: csala/mdformat-simple-breaks#5

@csala
Copy link
Owner

csala commented Oct 27, 2025

@kdeldycke Allowing the workflow unveiled some problems. I fixed one directly on the github web editor, but now more are showing up. Do you want to take a look? I'm happy to continue on my own, but since the PR was originally yours I feel like overstepping.

It's mostly references that were lost on the conflict resolution, but the web editor is really not user friendly at all to fix these things.

@kdeldycke
Copy link
Contributor Author

Hmmm. Ah yes, I guess I produce this PR after #20, hence the mixed up...

OK I can fix this one if you prefer.

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.50%. Comparing base (93e3972) to head (3b04bd3).

Files with missing lines Patch % Lines
mdformat_pyproject/plugin.py 77.77% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   97.29%   92.50%   -4.80%     
==========================================
  Files           2        2              
  Lines          37       40       +3     
==========================================
+ Hits           36       37       +1     
- Misses          1        3       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kdeldycke
Copy link
Contributor Author

OK I just made the last edits to only introduce minimal changes. All tests are passing. I guess you can squash-merge this PR if it's OK to you.

@csala csala merged commit 35ebee6 into csala:master Oct 27, 2025
13 checks passed
@kdeldycke
Copy link
Contributor Author

Thanks for the merge! :)

@kdeldycke kdeldycke deleted the modernize-typing branch October 27, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants