fix(sqlite-driver) Update tablesSchema #10031
Open
+72
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr:community
LFischerstrom
changed the title
KSDaemon
reviewed
Oct 7, 2025
There was a problem hiding this comment.
@LFischerstrom cool! Thank you for this improvement and fix!
| "scripts": { | ||
| "lint": "eslint **/*.js" | ||
| "lint": "eslint **/*.js", | ||
| "test": "jest ./**/*.test.js" |
There was a problem hiding this comment.
Let's rename (or just add an alias) unit so this test could run in CI unit tests with lerna run unit - that would be useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made
The current implementation of
tableSchemadoesn't pass the tests added in this PR.To pass the tests (and improve on readability) we can use
pragma_table_info(<tableName>)to list the column names and their type. This results in N+1 queries but this is not an issue with SQLite https://www.sqlite.org/np1queryprob.html