feat(query-ocherator): QueryCache - improve usage of in-memory cache #9838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a broken logic, which doesn't allow us to cache short refresh keys in memory. Due to this bug, instead of caching keys with short life time in
QueryQueue
's in-memory cache, we get keys from Cache Store. It's fast, 1-3 ms for key lookup, but there is no reason to do that.I don't want to spend a lot of time on benchmarking. I did a simple benchmark, 10 runs, the fastest I've uploaded. It's just a simple query with 1 measure and 1 dimension, which queries a cube with a 5-minute refresh key and pre-agg with build_range.
before
after