encoding/toml: fix decoding subtable duplicate keys #4027
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theoretick
force-pushed
the
fix-toml-subtable-decoding
branch
3 times, most recently
from
cfb7db2 to
10b0a94
Compare
mvdan
approved these changes
Aug 15, 2025
theoretick
force-pushed
the
fix-toml-subtable-decoding
branch
from
10b0a94 to
c7f580f
Compare
Previously, subtables with duplicate keys fail to be decoded even though they represent valid TOML. Instead we should track `seenTableKeys` by the array index to ensure duplication is local to the given object Fixes cue-lang#3609 Signed-off-by: Lucas Charles <[email protected]>
theoretick
force-pushed
the
fix-toml-subtable-decoding
branch
from
c7f580f to
2da898c
Compare
|
@mvdan I'm not sure what's causing this test failure 🤔 would you mind taking a look? |
|
@theoretick my best guess is that you need to rebase on master. I don't see how your changes could cause such a failure other than not being up to date with master. |
|
I'll rebase as I import the patch into Gerrit, assuming that will fix CI. |
|
Imported as https://review.gerrithub.io/c/cue-lang/cue/+/1221525. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, subtables with duplicate keys fail to be decoded even though they represent valid TOML. Instead we should track seenTableKeys by the array index to ensure duplication is local to the given object
Fixes #3609