-
Notifications
You must be signed in to change notification settings - Fork 3.3k
dependency: update dependency webpack-dev-server to v5.2.1 [security] #32235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependency: update dependency webpack-dev-server to v5.2.1 [security] #32235
Conversation
See the guidelines for reviewing dependency updates for info on how to review dependency update PRs. |
1bd98f6
to
9accb00
Compare
8599567
to
2ee8ba8
Compare
2ee8ba8
to
2f4c73b
Compare
…://github.com/cypress-io/cypress into renovate/npm-webpack-dev-server-vulnerability
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
cypress
|
Project |
cypress
|
Branch Review |
renovate/npm-webpack-dev-server-vulnerability
|
Run status |
|
Run duration | 19m 43s |
Commit |
|
Committer | Bill Glesias |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
12
|
|
1102
|
|
0
|
|
26661
|
View all changes introduced in this branch ↗︎ |
UI Coverage
44.99%
|
|
---|---|
|
187
|
|
157
|
Accessibility
97.71%
|
|
---|---|
|
4 critical
8 serious
2 moderate
2 minor
|
|
110
|
@AtofStryker A few of these error stacktraces look slightly different in the snapshots. |
@jennifer-shehane snapshots are now updated |
…/npm-webpack-dev-server-vulnerability
This PR contains the following updates:
5.1.0
->5.2.1
GitHub Vulnerability Alerts
CVE-2025-30360
Summary
Source code may be stolen when you access a malicious web site with non-Chromium based browser.
Details
The
Origin
header is checked to prevent Cross-site WebSocket hijacking from happening which was reported by CVE-2018-14732.But webpack-dev-server always allows IP address
Origin
headers.https://github.com/webpack/webpack-dev-server/blob/55220a800ba4e30dbde2d98785ecf4c80b32f711/lib/Server.js#L3113-L3127
This allows websites that are served on IP addresses to connect WebSocket.
By using the same method described in the article linked from CVE-2018-14732, the attacker get the source code.
related commit: webpack/webpack-dev-server@72efaab (note that
checkHost
function was only used for Host header to prevent DNS rebinding attacks so this change itself is fine.This vulnerability does not affect Chrome 94+ (and other Chromium based browsers) users due to the non-HTTPS private access blocking feature.
PoC
npm i
npx webpack-dev-server
http://{ipaddress}/?target=http://localhost:8080&file=main
with a non-Chromium browser (I used Firefox 134.0.1)src/index.js
in the extracted directorysrc/index.js
The script in the POC site is:
Impact
This vulnerability can result in the source code to be stolen for users that uses a predictable port and uses a non-Chromium based browser.
CVE-2025-30359
Summary
Source code may be stolen when you access a malicious web site.
Details
Because the request for classic script by a script tag is not subject to same origin policy, an attacker can inject
<script src="http://localhost:8080/main.js">
in their site and run the script. Note that the attacker has to know the port and the output entrypoint script path. Combined with prototype pollution, the attacker can get a reference to the webpack runtime variables.By using
Function::toString
against the values in__webpack_modules__
, the attacker can get the source code.PoC
npm i
npx webpack-dev-server
https://e29c9a88-a242-4fb4-9e64-b24c9d29b35b.pages.dev/
The script in the POC site is:
This script uses the function generated by
renderRequire
.Especially, it uses the fact that
Array::forEach
is called for__webpack_require__.i
andexecOptions
contains__webpack_require__
.It uses prototype pollution against
Array::forEach
to extract__webpack_require__
reference.Impact
This vulnerability can result in the source code to be stolen for users that uses a predictable port and output path for the entrypoint script.
Old content
Summary
Source code may be stolen when you use
output.iife: false
and access a malicious web site.Details
When
output.iife: false
is set, some global variables for the webpack runtime are declared on thewindow
object (e.g.__webpack_modules__
).Because the request for classic script by a script tag is not subject to same origin policy, an attacker can inject
<script src="http://localhost:8080/main.js">
in their site and run the script. Note that the attacker has to know the port and the output entrypoint script path. By running that, the webpack runtime variables will be declared on thewindow
object.By using
Function::toString
against the values in__webpack_modules__
, the attacker can get the source code.I pointed out
output.iife: false
, but if there are other options that makes the webpack runtime variables to be declared on thewindow
object, the same will apply for those cases.PoC
npm i
npx webpack-dev-server
https://852aafa3-5f83-44da-9fc6-ea116d0e3035.pages.dev/
src/index.js
and other scripts loaded.The script in the POC site is:
Impact
This vulnerability can result in the source code to be stolen for users that has
output.iife: false
option set and uses a predictable port and output path for the entrypoint script.Release Notes
webpack/webpack-dev-server (webpack-dev-server)
v5.2.1
Compare Source
Security
Access-Control-Allow-Origin
headerOrigin
header are not allowed to connect to WebSocket server unless configured byallowedHosts
or it different from theHost
headerThe above changes may make the dev server not work if you relied on such behavior, but unfortunately they carry security risks, so they were considered as fixes.
Bug Fixes
v5.2.0
Compare Source
Features
getClientEntry
andgetClientHotEntry
methods to get clients entries (dc642a8)Bug Fixes
Configuration
📅 Schedule: Branch creation - "" in timezone America/New_York, Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.