Skip to content

Conversation

cacieprins
Copy link
Contributor

@cacieprins cacieprins commented Oct 8, 2025

Additional details

Most notably in CT, when running Cypress in development mode, the STDERR marking tokens were appearing in the final cli output. This:

  • Ensures that we are not adding tokens when we shouldn't (e.g., debugging electron, internal development mode for Cypress)
  • Ensures that we are not stripping tokens when we aren't adding them
  • Refactors to make this distinction easier to determine

Steps to test

Check out and build; run cypress:run --component --project ./packages/driver, ensure no tokens exist in the output

How has the user experience changed?

PR Tasks


Note

Disable stderr tag injection when ELECTRON_ENABLE_LOGGING=1 or in Cypress development mode, with refactors and tests updated accordingly.

  • stderr filtering:
    • Tag control: Introduce tagsDisabled() to centralize when tags are suppressed (ELECTRON_ENABLE_LOGGING=1 or CYPRESS_INTERNAL_ENV=development).
    • Filter (packages/stderr-filtering/lib/Filter.ts): remove disableTags arg; conditionally pipe through FilterTaggedContent only when tags are enabled.
    • TagStream (packages/stderr-filtering/lib/TagStream.ts): use tagsDisabled() to skip adding START_TAG/END_TAG; improve Buffer handling and move verbose logs to cypress-verbose:*.
    • logError (packages/stderr-filtering/lib/logError.ts): use tagsDisabled() to decide tagging; minor comment fix.
    • New: packages/stderr-filtering/lib/tagsDisabled.ts.
    • Tests: Update specs to stub env vars and validate tag suppression/enabling paths; adjust expectations for Buffer outputs and pipeline.
  • Docs:
    • Changelog: note reduced verbose bracketing of stderr messages in dev/ELECTRON logging.

Written by Cursor Bugbot for commit fdf7608. This will update automatically on new commits. Configure here.

@cacieprins cacieprins changed the title Fix: stderr tokens are no longer injected when in development mode fix: stderr tokens are no longer injected when in development mode Oct 8, 2025
@cacieprins cacieprins marked this pull request as ready for review October 8, 2025 13:51
@cacieprins cacieprins requested a review from AtofStryker October 8, 2025 13:52
cursor[bot]

This comment was marked as outdated.

Copy link

cypress bot commented Oct 8, 2025

cypress    Run #66387

Run Properties:  status check failed Failed #66387  •  git commit fdf7608cd9: Merge branch 'develop' into fix/stderr-tokens-dev-mode
Project cypress
Branch Review fix/stderr-tokens-dev-mode
Run status status check failed Failed #66387
Run duration 20m 16s
Commit git commit fdf7608cd9: Merge branch 'develop' into fix/stderr-tokens-dev-mode
Committer Cacie Prins
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 12
Tests that did not run due to a developer annotating a test with .skip  Pending 1102
Tests that did not run due to a failure in a mocha hook  Skipped 4
Tests that passed  Passing 26729
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  45.27%
  Untested elements 186  
  Tested elements 158  
Accessibility  97.97%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 101  

Tests for review

Failed  commands/files.cy.js • 1 failed test • 5x-driver-firefox

View Output

Test Artifacts
src/cy/commands/files > #readFile > retries assertions until they pass
    </td>
  </tr></table>
Failed  studio/studio.cy.ts • 1 failed test • app-e2e

View Output

Test Artifacts
Cypress Studio > updates an existing test with assertions Test Replay Screenshots
Flakiness  commands/files.cy.js • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > has implicit existence assertion and throws a specific error when file does not exist Test Replay
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Test Replay Screenshots
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-inject-document-domain-chrome:beta

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Test Replay Screenshots

The first 5 flaky specs are shown, see all 12 specs in Cypress Cloud.

cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

webpack info logs less readable with CYPRESS.STDERR annotations

2 participants