-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix: stderr tokens are no longer injected when in development mode #32674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cacieprins
wants to merge
13
commits into
develop
Choose a base branch
from
fix/stderr-tokens-dev-mode
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
Project |
cypress
|
Branch Review |
fix/stderr-tokens-dev-mode
|
Run status |
|
Run duration | 20m 16s |
Commit |
|
Committer | Cacie Prins |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
2
|
|
12
|
|
1102
|
|
4
|
|
26729
|
View all changes introduced in this branch ↗︎ |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.27%
|
|
---|---|
|
186
|
|
158
|
Accessibility
97.97%
|
|
---|---|
|
4 critical
8 serious
2 moderate
2 minor
|
|
101
|
Tests for review
commands/files.cy.js • 1 failed test • 5x-driver-firefox
AtofStryker
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Most notably in CT, when running Cypress in development mode, the STDERR marking tokens were appearing in the final cli output. This:
Steps to test
Check out and build; run
cypress:run --component --project ./packages/driver
, ensure no tokens exist in the outputHow has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?Note
Disable stderr tag injection when ELECTRON_ENABLE_LOGGING=1 or in Cypress development mode, with refactors and tests updated accordingly.
tagsDisabled()
to centralize when tags are suppressed (ELECTRON_ENABLE_LOGGING=1
orCYPRESS_INTERNAL_ENV=development
).packages/stderr-filtering/lib/Filter.ts
): removedisableTags
arg; conditionally pipe throughFilterTaggedContent
only when tags are enabled.packages/stderr-filtering/lib/TagStream.ts
): usetagsDisabled()
to skip addingSTART_TAG
/END_TAG
; improve Buffer handling and move verbose logs tocypress-verbose:*
.packages/stderr-filtering/lib/logError.ts
): usetagsDisabled()
to decide tagging; minor comment fix.packages/stderr-filtering/lib/tagsDisabled.ts
.stderr
messages in dev/ELECTRON logging.Written by Cursor Bugbot for commit fdf7608. This will update automatically on new commits. Configure here.