chore (draft): migrate extension to typescript and tests to vitest #32680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| const result = extension.getPathToV3Extension() | ||
| const expected = path.join(cwd, 'dist', 'v3') | ||
|
|
||
| expect(path.normalize(result)).toEqual(path.normalize(expected)) |
There was a problem hiding this comment.
Bug: Path Resolution Update Breaks Unit Tests
The getPathToExtension and getPathToV3Extension functions now resolve paths to app-dist instead of dist. This change causes their unit tests to fail and may break existing functionality that expects extension files in the dist directory.
Additional Locations (1)
cypress
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/extension_migration
|
| Run status |
|
| Run duration | 18m 21s |
| Commit |
|
| Committer | Bill Glesias |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
8
|
Flaky
|
10
|
Pending
|
1041
|
Skipped
|
4
|
Passing
|
21487
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.69%
|
|
|---|---|
|
Untested elements
|
184
|
|
Tested elements
|
159
|
Accessibility
97.97%
|
|
|---|---|
|
Failed rules
|
4 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
101
|
Tests for review
The first 5 failed specs are shown, see all 598 specs in Cypress Cloud.
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| ... > stops waiting when an fetch request is canceled |
Test Replay
|
|
commands/location.cy.js • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| ... > does not log an additional log on failure |
Test Replay
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ... > stops waiting when an xhr request is canceled |
| ||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary |
Test Replay
|
|
commands/waiting.cy.js • 2 flaky tests • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when route is never resolved |
Test Replay
|
|
| ... > errors > throws when waiting for 2nd response to route |
Test Replay
|
|
The first 5 flaky specs are shown, see all 8 specs in Cypress Cloud.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Migrates @packages/extension to TypeScript with Vitest tests, updates build outputs to app-dist/lib-dist, revamps webpack/gulp configs, and adjusts CI/docs.
app/v2,app/v3,lib); add types and exports; remove legacy JS/defs.app-dist/(app) andlib-dist/(library); update paths in helpers andgulpfile..spec.tsfiles; remove old JS specs and mocha opts).webpack.configto ESM, TypeScript entry, and output toapp-dist/v2/background.js.gulpfileto use@packages/iconsAPIs and yarn build steps; export tasks; new clean/build pipelines.package.jsonscripts (build:app/background/lib, vitest), setmaintolib-dist/index.js.tsconfig.*.json) andvitest.config.ts; ignoreapp-dist/,lib-dist/.automation.@types/webextension-polyfill.10to9.packages/extensionas completed in both phases.Written by Cursor Bugbot for commit 6772100. This will update automatically on new commits. Configure here.