test PR to close: test parametarized ci #32695
Open
+90
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed value for branch - migrates trigger-publish-binary-pipeline.js to an inlined bash script to speed it up and simplify it - adds a pipeline parameter that can be set via CircleCI UI to determine which branch we use in the publish-binary pipeline, to reduce file churn and human error - updates the packages/electron/README.md to include the simplified steps
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| fi | ||
|
|
||
| echo "Pipeline saved to triggered_pipeline.json" | ||
| echo "Triggered pipeline: https://app.circleci.com/pipelines/github/cypress-io/cypress-publish-binary/$(jq -r '.number' triggered_pipeline.json)" |
There was a problem hiding this comment.
Bug: Pipeline URL Error Due to File Path Mismatch
The jq command attempts to read triggered_pipeline.json from the current directory, but curl saves the file to ~/triggered_pipeline.json. This path mismatch prevents jq from finding the file, resulting in a broken pipeline URL in the output.
| "binary_version": "$NEXT_VERSION" | ||
| } | ||
| } | ||
| JSON_BODY_EOF |
There was a problem hiding this comment.
Bug: Pipeline Trigger Fails Due to JSON Interpolation
The JSON body for triggering the pipeline directly interpolates shell variables. This omits necessary JSON escaping for string values and boolean conversion for SHOULD_PERSIST_ARTIFACTS, which can lead to malformed JSON and pipeline trigger failures if variable contents are not strictly valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Adds a
publish-binary-branchpipeline parameter and switches binary publish triggering to a new CircleCI command, removing the old Node script.publish-binary-branchand pass it through continuation (.circleci/config.yml,.circleci/src/pipeline/@pipeline.yml).commands/trigger-publish-binary-pipeline.yml(uses curl/jq, parametertarget-repo-branch).create-and-trigger-packaging-artifactsto calltrigger-publish-binary-pipelinewithtarget-repo-branch: << pipeline.parameters.publish-binary-branch >>.scripts/binary/trigger-publish-binary-pipeline.js.packages/electron/README.mdchecklist to use the new parameterized flow and CircleCI UI trigger, adding guidance to setpublish-binary-branchand workflow filters.Written by Cursor Bugbot for commit 284b03d. This will update automatically on new commits. Configure here.