-
Couldn't load subscription status.
- Fork 3.4k
chore: (feature-branch), convert @packages/socket and @packages/extension into bundle packages and @packages/extension to vitest
#32748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/refactor-socket-and-extension
|
| Run status |
|
| Run duration | 19m 47s |
| Commit |
|
| Committer | Bill Glesias |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
12
|
|
|
1102
|
|
|
4
|
|
|
26752
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.61%
|
|
|---|---|
|
|
187
|
|
|
161
|
Accessibility
97.98%
|
|
|---|---|
|
|
4 critical
8 serious
2 moderate
2 minor
|
|
|
101
|
…test` (#32680) * chore: convert extension to TypeScript and vitest * chore: typecheck the whole package
|
@jennifer-shehane are you able to review the feature branch? only commit that isn't reviewed already is 2408fe5 just to get things synced with develop |
Bug: Incorrect SocketIO Imports Cause Module Resolution ErrorsThe Additional Locations (2) |
this is intentional until we are able to convert those tests to vitest. there is a giant comment where the import from source is happening |
USE A MERGE COMMIT
Additional details
contains PRs:
@packages/socket#32726@packages/extensiontoTypeScriptand tests toVitest#32680Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Splits
@packages/socketinto browser and node bundles and migrates@packages/extensionto TypeScript/Vitest with newapp-dist/lib-distbuilds, updating imports/tests across the repo and making minor server/proxy/CI adjustments.@packages/socket:browser/client) and node (cjs/node,esm/node) bundles with new entrypoints/exports (SocketIOServer,CDPSocketServer,client,createWebsocket).tsconfig.browser.json,tsconfig.cjs.json,tsconfig.esm.json); removed legacyindex.jsand reorganized sources.@packages/extension:.gitignore.app-dist/(v2 via webpack, v3 via tsc) andlib-dist/(CJS); rewrotegulpfile.tsandwebpack.config.mjs.lib/extension.jswithlib/index.ts; removedutil.js; added new TS configs and vitest config..spec.tsand updated mocks/types.@packages/socket/browser/client; server/types import from@packages/socket.packages/app,frontend-shared,network,servertests, and system tests.getCookieUrlinserver/lib/automation/cookies.ts(removed@packages/extensiondependency).CDPSocketServerfrom@packages/socketandextensionas module.@packages/errors.guides/esm-migration.mdstatus updates (extension/socket completed) and notes.4to3.Written by Cursor Bugbot for commit 2408fe5. This will update automatically on new commits. Configure here.