-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat: add support for Angular 21 #33004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ea970e7 to
0f3772b
Compare
cypress
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
feat/support_angular_21
|
| Run status |
|
| Run duration | 18m 52s |
| Commit |
|
| Committer | Bill Glesias |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
1
|
|
|
9
|
|
|
1097
|
|
|
4
|
|
|
26691
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.48%
|
|
|---|---|
|
|
188
|
|
|
161
|
Accessibility
97.99%
|
|
|---|---|
|
|
4 critical
8 serious
2 moderate
2 minor
|
|
|
101
|
Tests for review
src/runner/ResizablePanels.cy.tsx • 1 failed test • app-ct
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Test Replay
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary |
Test Replay
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-inject-document-domain-chrome
| Test | Artifacts | |
|---|---|---|
| cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary |
Test Replay
|
|
The first 5 flaky specs are shown, see all 9 specs in Cypress Cloud.
0f3772b to
d8271ce
Compare
d8271ce to
050dc8a
Compare
050dc8a to
da19b3f
Compare
da19b3f to
0d85a78
Compare
38907b6 to
8d18b26
Compare
system-tests/project-fixtures/angular/src/app/components/counter.component.ts
Show resolved
Hide resolved
…recommended approach since then
5d5b79a to
cc8305a
Compare
jennifer-shehane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct. If you are using |


Additional details
Adds support for Angular 21 within Cypress Component testing. Right now the Angular 21 projects needs
zone.jsas adevDependencyascypress/angularcurrently only supports zone.js. I have a follow up PR #33025 that adds a zoneless mount handler and defaults the scaffolding tocypress/angular-zonelessfor Angular 21 applicationsAs Angular 21's change detection is a bit different from the legacy implementations, I refactored some of the angular fixtures to use signals instead of observables as signals are fully supported as of angular 18+
Steps to test
use the prepublished binaries to make sure scaffolding works on a new angular 21 project
How has the user experience changed?
Users will now be able to use Angular 21 without Cypress scaffolding warnings. NOTE: this currently still requires the zone.js devDependency until the zoneless mount handler is merged down. The intent is for both of these two be shipped at the same time but the work is considered separate.
PR Tasks
cypress-documentation? chore: add angular 21 and zoneless documentation cypress-documentation#6326type definitions?Note
Adds Angular 21 support across component testing, scaffolding, CI, and docs, with new fixtures/tests and dependency updates.
system-tests/projects/angular-21(config, deps, tsconfig, cypress aliases forzone.js/Angular packages).angular-21(webpack-dev-server e2e, component_testing_spec).cli/CHANGELOG.md.^21.0.0inpackages/scaffold-config/src/dependencies.ts.20.x/21.x.fetchin Angular example components/services.mount.cy.ts) to dropHttpClientModule, usecomponentRef.setInput, and Promise-based service doubles.angular-21to webpack dev-server E2E; updateangularHandlertests for Angular 20/21 build options and tsconfig generation flag.feat/support_angular_21and artifact persist conditions.Written by Cursor Bugbot for commit 3a67480. This will update automatically on new commits. Configure here.