Update class.php #92
Open
Update class.php #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed Virtual Pages content Translation Issue
|
I found a page where the fix does not work. |
|
The not Page where it was not fixed was a fluke. It was cached and now it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Virtual Pages content Translation Issue
class.php changed:
$this->_setPageLanguage($page, $languageCode, false); to $this->_setPageLanguage($page, $languageCode);
as it now properly sets the languages for Virtual Pages
Description/Motivation
So I Stumbled upon a Problem generation our Multipage project. We have a few Plugins That use Virtual Pages and Multi Language Support now I created a script to load the Pages into the static site generator. It works fine, but the Translations didn't seem to work. I debugged a little bit and this was the first working version.
Testing
So I just tested it With a Script and Custom Routes.
Related issue
New