Skip to content

Conversation

@zhichli
Copy link
Contributor

@zhichli zhichli commented Jul 18, 2025

Address #159 [Feature]: Native windows support for VS Code and Visual Studio 2022 with GH Copilot #159 based on #91 ai generated windows build, untested #91

Major callouts:

Future steps:

  • go release for windows
  • installation script update for windows
  • docs update

@zhichli
Copy link
Contributor Author

zhichli commented Jul 18, 2025

For release and installation, @cwlbraa I've not looked into this process in detail, so some hint or pointers would be great.

@zhichli
Copy link
Contributor Author

zhichli commented Jul 18, 2025

For doc updates, @jpadams it would be great if you could help here, or point me where changes are needed

@cwlbraa cwlbraa requested a review from grouville July 18, 2025 23:49
@jpadams
Copy link
Contributor

jpadams commented Jul 19, 2025

@zhichli @cwlbraa would be great to have the Windows install use winget install like we do with the dagger cli: https://docs.dagger.io/install

We can kick off a PR here: https://github.com/microsoft/winget-pkgs/blob/master/doc/README.md#authoring-a-manifest

For docs @zhichli, happy to help when I'm back on Monday with my Windows machine to confirm things.
I figure we'll need:

@aluzzardi
Copy link
Member

@grouville is looking into this!


package main

// On Windows, SIGUSR1 is not available, so we provide a no-op implementation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add another way to dump the stack on Windows, but at the moment, it's totally fine 👍

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious to know what way you are suggesting? I'm learning go along the way, so pls educate me.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, BTW, this is my alternative github account of @zhichli.

@grouville
Copy link
Member

grouville commented Jul 23, 2025

@zhichli Force pushed to resolve the go.sum. I have follow-ups (the entire windows pipeline + docs + package managers) ready

@grouville grouville self-requested a review July 23, 2025 22:44
Copy link
Member

@grouville grouville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing contribution 🙏

@grouville grouville merged commit 122c5db into dagger:main Jul 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants