fix: remove elements appended to body in ngf-select on $destroy #2056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the directive is added to something other than a file input, it adds file input elements to the document body. Since these are outside of the element the directive is applied to, they aren't automatically removed at the end of its life. The cleanup code for these elements already existed, but it was only being called once when the directive was first applied, and wasn't doing anything. Now it will be called on $destroy, and the file elements are correctly removed
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the directive is added to something other than a file input, it adds
file input elements to the document body. Since these are outside of the
element the directive is applied to, they aren't automatically removed at
the end of its life.
The cleanup code for these elements already existed, but it was only being called
once when the directive was first applied, and wasn't actually removing anything. Now it
will be called on $destroy, and the file elements are correctly removed