Skip to content

Conversation

@tonyOreglia
Copy link

The branch works for scripts sitting in a Team Drive by adding the parameter supportsTeamDrives to the upload request.

fixes the problem for a team drive

I've added this as an addition option. I.e.

gapps push --teamdrive 

@lricoy
Copy link
Collaborator

lricoy commented Nov 29, 2017

Fixes #61

@lricoy
Copy link
Collaborator

lricoy commented Nov 29, 2017

Code: LGTM but could you please change the README in order to:

  • Include the new option under the Docs section for the upload command.
  • Add a item in the Common Issues section with your comments about Team Drive
  • Fix conflicts :)


module.exports = function upload() {
module.exports = function upload(options) {
// console.log(options)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean this ? :)

};

if (supportsTeamDrives) {
console.log('teamdrive=true')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about editing the message that shows up when uploading (something like "Pushing back up to Google Drive (target project is inside a Team Drive)..."?

@@ -1,3 +1,24 @@
The branch works for scripts sitting in a Team Drive by adding the parameter supportsTeamDrives to the upload request.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't say better than @lricoy comment about updating the README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants