NBA-3112 : Added Contract NFT Display Data #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
judezhu
changed the title
Deewai
previously approved these changes
Sep 18, 2024
Collaborator
Deewai
left a comment
Deewai
left a comment
There was a problem hiding this comment.
LGTM! just a comment on the image url
Contributor
joshuahannan
left a comment
joshuahannan
left a comment
There was a problem hiding this comment.
Make sure you also update getContractViews() to add NFTCollectionDisplay to that too
Collaborator
Author
updated it here: 466da66 . |
joshuahannan
approved these changes
Sep 21, 2024
Contributor
joshuahannan
left a comment
joshuahannan
left a comment
There was a problem hiding this comment.
Thank you! Do you have a plan for the actual upgrade?
Collaborator
Author
@joshuahannan just upgraded ✅ . Is there a way to check if the metadata view works on 3rd party site now? |
joshuahannan
approved these changes
Sep 23, 2024
Contributor
|
Not sure. I just told the find team that y'all updated and they'll probably verify |
Deewai
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.