fix(kinesis): prevent stream ARN resolution in SharedThroughput mode #3981
+17
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #3980 |
Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: swatimodi-scout <[email protected]>
…ponent (dapr#3853) Signed-off-by: Prashanth Nagaraj <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: swatimodi-scout <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]> Signed-off-by: swatimodi-scout <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]>
…rors - Invoke logic only when KinesisConsumerMode is set to 'extended' to avoid unnecessary calls - Skip next step if error is not nil to prevent nil pointer errors on StreamDescription.StreamARN. Signed-off-by: swatimodi-scout <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]>
Signed-off-by: Filinto Duran <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Signed-off-by: swatimodi-scout <[email protected]>
…re Service Bus Topics. (dapr#3942) Signed-off-by: Andy Ladd <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Signed-off-by: swatimodi-scout <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Signed-off-by: swatimodi-scout <[email protected]>
…apr#3914) Signed-off-by: Mike Nguyen <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Signed-off-by: swatimodi-scout <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]> Signed-off-by: swatimodi-scout <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]> Signed-off-by: swatimodi-scout <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]> Signed-off-by: swatimodi-scout <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]> Signed-off-by: swatimodi-scout <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]> Signed-off-by: swatimodi-scout <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]> Co-authored-by: peterdalinis-scout <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Signed-off-by: swatimodi-scout <[email protected]>
Signed-off-by: nelson.parente <[email protected]> Signed-off-by: swatimodi-scout <[email protected]>
Signed-off-by: Oliver Tomlinson <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Signed-off-by: swatimodi-scout <[email protected]>
Signed-off-by: Mike Nguyen <[email protected]> Signed-off-by: swatimodi-scout <[email protected]>
Signed-off-by: Mike Nguyen <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Signed-off-by: swatimodi-scout <[email protected]>
…#3969) Signed-off-by: Samantha Coyle <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Signed-off-by: swatimodi-scout <[email protected]>
Signed-off-by: Eileen Yu <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Signed-off-by: swatimodi-scout <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Signed-off-by: swatimodi-scout <[email protected]>
yaron2
previously approved these changes
Aug 19, 2025
|
|
Signed-off-by: swatimodi-scout <[email protected]>
Fixed |
|
@yaron2 Please review the PR again. |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the AWS Kinesis input binding where the stream ARN was being resolved unconditionally, even when
KinesisConsumerModewas set toSharedThroughput(the default).authProvider.Kinesis().Stream(...)regardless of the consumer mode.SharedThroughputmode, this resulted in nil pointer errors if the stream was unavailable or not initialized. This was encountered during local testing with LocalStack but can occur in any environment.KinesisConsumerModeis set toExtendedFanout.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[3980]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Note: We expect contributors to open a corresponding documentation PR in the dapr/docs repository. As the implementer, you are the best person to document your work! Implementation PRs will not be merged until the documentation PR is opened and ready for review.