improve redis getkeyversion #3990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
… not added just comparison) Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
filintod
commented
Aug 26, 2025
|
|
||
| // ~8x speed - ~1/2 allocations | ||
|
|
||
| // unsafe comparison |
There was a problem hiding this comment.
this is just for comparison with a run changing toString method to use unsafe []byte->string. In many cases it would be fine but leaving for future if really needed it could be added as an option
JoshVanL
approved these changes
Aug 26, 2025
|
@yaron2 should I put this in the 1.16 branch? or leave for later |
|
Linter needs go mod tidy |
|
@yaron2 I think that was coming from the main branch after I updated it here, but it seems fine after you updated it again |
filintod
added a commit
to filintod/components-contrib
that referenced
this pull request
Aug 29, 2025
Signed-off-by: Filinto Duran <[email protected]> Co-authored-by: Yaron Schneider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After checking some profiling in one of our programs that makes use of this method, we noticed that a lot of the allocations and cpu time was sunk on this method
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Note: We expect contributors to open a corresponding documentation PR in the dapr/docs repository. As the implementer, you are the best person to document your work! Implementation PRs will not be merged until the documentation PR is opened and ready for review.