-
Notifications
You must be signed in to change notification settings - Fork 780
Chore: jaeger guidance #4923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v1.16
Are you sure you want to change the base?
Chore: jaeger guidance #4923
Conversation
msfussell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More comments/updates
| docker logs jaeger | ||
| ``` | ||
|
|
||
| Next, create the following `config.yaml` file locally: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other edit you can do here is say that in the development environment navigate to the local dapr folder (add this reference link https://docs.dapr.io/getting-started/install-dapr-selfhost/#step-5-verify-components-directory-has-been-initialized) and update the default config.yaml file with these changes.
Can I also suggest that in this article https://docs.dapr.io/getting-started/install-dapr-selfhost/ we add an "Optional Step 6. Configure JaegerV2 for local tracing instead of Zipkin" and then add a link to this article. That is to give people a choice of the local tracing experience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other things to update
"1. Create a configuration file (e.g., tracing.yaml)" - Should be ->"1. Create a configuration file (for example tracing.yaml)
-
Why install cert- manager? And if so, why is this setting
isSecure: false. I would expect that we show how to install secure connect with a cert (hence cert-manager yes)? -
Is this namespace below correct between the deployment and when you say "opentelemetry-operator-system" namespace?
Confirm that all resources in the opentelemetry-operator-system namespace are ready.
Deploy a Jaeger V2 instance with in-memory storage:
Apply the following configuration to create a Jaeger V2 instance:
apiVersion: opentelemetry.io/v1beta1
kind: OpenTelemetryCollector
metadata:
name: jaeger-inmemory-instance
namespace: observabilityThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why install cert- manager? And if so, why is this setting isSecure: false. I would expect that we show how to install secure connect with a cert (hence cert-manager yes)?
Cert-manager is required for the otel-operator webhook to communicate with the API server, but for the purpose of this guide, we can simplify the installation.and use the automatically generated self-signed certificate option by setting admissionWebhooks.certManager.enabled to false and admissionWebhooks.autoGenerateCert.enabled to true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this namespace below correct between the deployment and when you say "opentelemetry-operator-system" namespace?
Yes, the Operator runs in opentelemetry-operator-system, and it manages the jeager instance deployment in observability.
msfussell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more comments
...ontent/en/operations/observability/tracing/otel-collector/open-telemetry-collector-jaeger.md
Outdated
Show resolved
Hide resolved
...ontent/en/operations/observability/tracing/otel-collector/open-telemetry-collector-jaeger.md
Outdated
Show resolved
Hide resolved
…tainer Signed-off-by: MyMirelHub <[email protected]>
Signed-off-by: MyMirelHub <[email protected]>
Signed-off-by: MyMirelHub <[email protected]>
…ector/open-telemetry-collector-jaeger.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Mirel <[email protected]> Signed-off-by: MyMirelHub <[email protected]>
Signed-off-by: MyMirelHub <[email protected]>
aaa57e6 to
599494d
Compare
Description
dapr init)dapr_zipkincontainer before starting Jaeger-dflag to run Jaeger detached in the backgroundIssue reference
#4920