-
Notifications
You must be signed in to change notification settings - Fork 780
docs: Clarify max-body-size applies to requests and responses (v1.16.3) #4935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jukhancisco
wants to merge
5
commits into
dapr:v1.16
Choose a base branch
from
jukhancisco:docs/clarify-max-body-size-annotation
base: v1.16
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
docs: Clarify max-body-size applies to requests and responses (v1.16.3) #4935
jukhancisco
wants to merge
5
commits into
dapr:v1.16
from
jukhancisco:docs/clarify-max-body-size-annotation
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Updated the max-body-size annotation description to clarify that it applies to: - Incoming HTTP/gRPC requests to the Dapr sidecar - Actor operation responses - Binding component responses (added in v1.16.2) This clarification helps users understand that the annotation controls both request and response body sizes, not just incoming requests. Fixes: dapr/components-contrib#4076 Related: dapr/dapr#9151 Signed-off-by: Junaid Khan <[email protected]>
85d6601 to
50225c0
Compare
JoshVanL
approved these changes
Nov 7, 2025
The binding component response size enforcement fix is now targeting v1.16.3 release instead of v1.16.2 (which was already released). Updated the annotation documentation to reflect the correct version. Signed-off-by: Junaid Khan <[email protected]>
cicoyle
approved these changes
Nov 10, 2025
msfussell
reviewed
Dec 4, 2025
| | `--dapr-http-port` | `--dapr-http-port` | | not supported | HTTP port for the Dapr API to listen on (default `3500`) | | ||
| | `--dapr-http-max-request-size` | `--dapr-http-max-request-size` | | `dapr.io/http-max-request-size` | **Deprecated** in favor of `--max-body-size`. Inreasing the request max body size to handle large file uploads using http and grpc protocols. Default is `4` MB | | ||
| | `--max-body-size` | not supported | | `dapr.io/max-body-size` | Inreasing the request max body size to handle large file uploads using http and grpc protocols. Set the value using size units (e.g., `16Mi` for 16MB). The default is `4Mi` | | ||
| | `--max-body-size` | not supported | | `dapr.io/max-body-size` | Maximum size for HTTP/gRPC request and response bodies. Applies to incoming requests to the Dapr sidecar, actor operations, and binding component responses. Useful for handling large file uploads/downloads. Set the value using size units (e.g., `16Mi` for 16MB). The default is `4Mi`. Note: Binding component response size enforcement added in Dapr v1.16.3. | |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just have to be clear if this is when this was added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR clarifies the documentation for the
dapr.io/max-body-sizeannotation to explicitly state that it applies to both request and response bodies, not just incoming requests.Target: v1.16 documentation (for Dapr v1.16.3 release)
Changes
Updated the
max-body-sizeannotation description in the arguments and annotations reference to clarify that it applies to:Previous Description
New Description
Why This Change?
Users were confused about the scope of the
max-body-sizeannotation. The fix in PR dapr/dapr#9151 (targeting v1.16.3) ensures binding components also respect this annotation, fixing issue dapr/dapr#9177.This documentation update helps users understand:
Related Issues/PRs
Checklist