-
Notifications
You must be signed in to change notification settings - Fork 362
Consolidate client registration implementation #1503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
WhitWaldo
merged 16 commits into
dapr:release-1.16
from
WhitWaldo:consolidate-service-registration
Apr 1, 2025
Merged
Consolidate client registration implementation #1503
WhitWaldo
merged 16 commits into
dapr:release-1.16
from
WhitWaldo:consolidate-service-registration
Apr 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… packages to reduce code duplication throughout. Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
…n each client type Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
…mpty constructor overload in client builders. Signed-off-by: Whit Waldo <[email protected]>
… other clients for consistency. Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
…g. implements IDisposable, primary constructors, use of generic service registration extension) Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
…aming - no need to introduce a breaking change here. Signed-off-by: Whit Waldo <[email protected]>
…e issues identified with Dapr.Common.Tests unit tests Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
This was referenced Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To date, we have several standalone clients from the standard
Dapr.Client
package and these use a common static client builder alongside separate (but similar) static extension registration methods. This PR eliminates duplicate code by introducing a common generic extension method that each of these standalone clients utilize instead of their current separate-but-identical approaches.This also consolidates how the clients are built to have them work in a consistent way through.
Dapr.Jobs
now reflects the same internalDaprJobsGrpcClient
as the other client.IDisposable
to do cleanup on their respectiveHttpClient
instances.Added unit tests throughout to validate everything.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: