-
Notifications
You must be signed in to change notification settings - Fork 223
Add Failure Policy for Jobs SDK #1448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Failure Policy for Jobs SDK #1448
Conversation
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: sirivarma <[email protected]>
Signed-off-by: sirivarma <[email protected]>
Signed-off-by: sirivarma <[email protected]>
The integration test will fail because a version of dapr that supports failures policy has not been released yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siri-varma nice patch! I have added some comments, mostly around naming convention.
sdk/src/main/java/io/dapr/client/domain/JobFailurePolicyConstant.java
Outdated
Show resolved
Hide resolved
sdk/src/main/java/io/dapr/client/domain/JobFailurePolicyDrop.java
Outdated
Show resolved
Hide resolved
@siri-varma could you please check why the some tests are failing:
|
Signed-off-by: Siri Varma Vegiraju <[email protected]>
* upgrading to 1.15.7 Signed-off-by: salaboy <[email protected]> * using DAPR VERSION Signed-off-by: salaboy <[email protected]> --------- Signed-off-by: salaboy <[email protected]> Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
b97a600
to
6a07cb3
Compare
@artur-ciocanu Once a new version with the required protos comes out, the integration tests should succeed. |
Signed-off-by: sirivarma <[email protected]>
Signed-off-by: sirivarma <[email protected]>
Signed-off-by: sirivarma <[email protected]>
Signed-off-by: sirivarma <[email protected]>
Signed-off-by: sirivarma <[email protected]>
Signed-off-by: sirivarma <[email protected]>
Users/svegiraju/test latest
@dapr/approvers-java-sdk This PR is ready for review. Thank you. |
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Fixed all the merge conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siri-varma overall looks good, but I think the code that deals with failure policy could be a little bit simple. Ideally you should use helper methods and ensure that you leverage early returns to avoid all those nested if/else.
Signed-off-by: sirivarma <[email protected]>
…om/siri-varma/java-sdk into users/svegiraju/add-failure-policy
Signed-off-by: sirivarma <[email protected]>
@artur-ciocanu Addressed all the comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice patch! Thank you.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1448 +/- ##
============================================
+ Coverage 76.91% 78.73% +1.81%
- Complexity 1592 1918 +326
============================================
Files 145 237 +92
Lines 4843 5924 +1081
Branches 562 610 +48
============================================
+ Hits 3725 4664 +939
- Misses 821 938 +117
- Partials 297 322 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Add Failure Policy for the Job
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1429
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: