Remove shaded deps #1543
Open
Remove shaded deps #1543
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matheus Cruz <[email protected]>
mcruzdev
force-pushed
the
remove-shaded-deps
branch
from
3dffdf6 to
7477f84
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1543 +/- ##
============================================
+ Coverage 76.91% 78.89% +1.98%
- Complexity 1592 1937 +345
============================================
Files 145 237 +92
Lines 4843 5956 +1113
Branches 562 611 +49
============================================
+ Hits 3725 4699 +974
- Misses 821 938 +117
- Partials 297 319 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
siri-varma
reviewed
Sep 8, 2025
| import io.grpc.netty.shaded.io.netty.handler.ssl.util.InsecureTrustManagerFactory; | ||
| import io.grpc.netty.GrpcSslContexts; | ||
| import io.grpc.netty.NettyChannelBuilder; | ||
| import io.netty.handler.ssl.util.InsecureTrustManagerFactory; |
There was a problem hiding this comment.
As per this thread, shaded is still recommended
There was a problem hiding this comment.
Yeah, but for native compilation it is a disaster.
There was a problem hiding this comment.
Is there a link for the description in the PR ? Would like to read more about it
There was a problem hiding this comment.
I do not have, I got those comments on the Quarkus Zulip.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I am not sure if this one is the best way to solve some issues related to native compilation. For Spring Native and Quarkus the
grpc-netty-shadedis not recommended due to recents CVEs and a lot of GraalVM configurations and substitutions.I am not an expertise in the netty subject, I appreciate any suggestions and comments about this change.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: