Centralize Maven dependency version management #1564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing version properties to parent POM - Convert hardcoded dependency versions to properties in parent dependencyManagement - Remove hardcoded versions from child modules - Add missing dependencies to parent dependencyManagement - Ensure all shared dependencies inherit versions from parent Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
|
@dapr/approvers-java-sdk could you please take a look. My only concern is Java Durable Task Client dependency that uses a weird version on Jackson. @javier-aliaga it would be good if you could take a look. @salaboy and @cicoyle I am not sure what should we do to get rid of |
Signed-off-by: Artur Ciocanu <[email protected]>
siri-varma
approved these changes
Sep 27, 2025
|
Thanks @artur-ciocanu ! LGTM. I think the required check is in a configuration section but I do not have access. |
javier-aliaga
approved these changes
Oct 2, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1564 +/- ##
============================================
+ Coverage 76.91% 78.51% +1.59%
- Complexity 1592 1912 +320
============================================
Files 145 215 +70
Lines 4843 5827 +984
Branches 562 649 +87
============================================
+ Hits 3725 4575 +850
- Misses 821 914 +93
- Partials 297 338 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dependencyManagementdependencyManagementIssue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
This PR is trying to address this issue: #1565
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: