Skip to content

Java Quickstart -> Tutorial for Dapr Univ Workflows Track #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 60 commits into from
Aug 21, 2025
Merged

Java Quickstart -> Tutorial for Dapr Univ Workflows Track #1195

merged 60 commits into from
Aug 21, 2025

Conversation

salaboy
Copy link
Contributor

@salaboy salaboy commented May 27, 2025

Description

Adding the first Java tutorial for Dapr Univ

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1194

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@salaboy salaboy requested review from a team as code owners May 27, 2025 14:15
@salaboy salaboy force-pushed the 1194-addind-java-tutorial branch from eddc02d to 9ab7cfa Compare May 27, 2025 14:15
@salaboy
Copy link
Contributor Author

salaboy commented May 28, 2025

@marcduiker hmm.. flaky cshapr test?

marcduiker
marcduiker requested changes May 28, 2025
View reviewed changes
Copy link
Contributor

@marcduiker marcduiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! I only like to see the DaprHttpPort as a fixed value.

@alicejgibbons
Copy link
Contributor

Putting Do not merge until we get the final 1.15 release

@alicejgibbons alicejgibbons added the do-not-merge Do not merge the PR label May 28, 2025
alicejgibbons
alicejgibbons requested changes May 28, 2025
View reviewed changes
@salaboy salaboy changed the title Task Chaining Java Tutorial for Dapr Univ Java Quickstart -> Tutorial for Dapr Univ Workflows Track Jun 16, 2025
@salaboy salaboy force-pushed the 1194-addind-java-tutorial branch from 5d674d8 to 16e4a4c Compare June 16, 2025 05:31
marcduiker
marcduiker requested changes Jun 16, 2025
View reviewed changes
Copy link
Contributor

@marcduiker marcduiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a clarification can be added about the instanceId then I think this pattern is complete.

@salaboy salaboy force-pushed the 1194-addind-java-tutorial branch 3 times, most recently from 50601f2 to 080217d Compare June 18, 2025 10:06
@salaboy
Copy link
Contributor Author

salaboy commented Jun 18, 2025

@marcduiker is there any way to run the quickstarts to validate them?

@alicejgibbons
Copy link
Contributor

alicejgibbons commented Jun 18, 2025 •
edited
Loading

The quickstarts have been validated @salaboy, just waiting on the official java non-rc version

marcduiker
marcduiker requested changes Jul 11, 2025
View reviewed changes
Copy link
Contributor

@marcduiker marcduiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes need to be addressed.

@alicejgibbons
Copy link
Contributor

The quickstarts have been validated @salaboy, just waiting on the official java non-rc version

As discussed, lets roll the sdk version back to get this out

@salaboy salaboy force-pushed the 1194-addind-java-tutorial branch 3 times, most recently from 0b4e013 to 00dc69f Compare August 12, 2025 13:41
@alicejgibbons
Copy link
Contributor

Dapr java sdk 1.15.0 is out now too :)

@salaboy salaboy force-pushed the 1194-addind-java-tutorial branch from 84222d1 to 146a708 Compare August 18, 2025 09:07
marcduiker
marcduiker requested changes Aug 18, 2025
View reviewed changes
@salaboy salaboy force-pushed the 1194-addind-java-tutorial branch from 0d4112d to 62a116c Compare August 18, 2025 09:57
marcduiker
marcduiker previously approved these changes Aug 18, 2025
View reviewed changes
Copy link
Contributor

@marcduiker marcduiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks @salaboy!

cicoyle added 2 commits August 18, 2025 11:48
@cicoyle @salaboy
update java to latest rc
94d32ef 
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: salaboy <[email protected]>
@cicoyle @salaboy
update springboot + wf
96e3da0 
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: salaboy <[email protected]>
cicoyle and others added 22 commits August 18, 2025 11:48
@cicoyle @salaboy
try 1.14.1
3251cf5 
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: salaboy <[email protected]>
@siri-varma @salaboy
Update job-service.go
de6ac8d 
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: salaboy <[email protected]>
@siri-varma @salaboy
Fix workflow
1cf4b67 
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: salaboy <[email protected]>
@salaboy @marcduiker
Update tutorials/workflow/java/monitor-pattern/src/main/java/io/dapr/…
181df1b 
…springboot/examples/monitor/MonitorWorkflow.java

Co-authored-by: Marc Duiker <[email protected]>
Signed-off-by: salaboy <[email protected]>
@salaboy @marcduiker
Update tutorials/workflow/java/external-system-interactions/externale…
dc56be1 
…vents.http

Co-authored-by: Marc Duiker <[email protected]>
Signed-off-by: salaboy <[email protected]>
@salaboy @marcduiker
Update tutorials/workflow/java/external-system-interactions/externale…
4493121 
…vents.http

Co-authored-by: Marc Duiker <[email protected]>
Signed-off-by: salaboy <[email protected]>
@salaboy @marcduiker
Update tutorials/workflow/java/external-system-interactions/src/main/…
ca48f42 
…java/io/dapr/springboot/examples/external/ExternalEventsWorkflow.java

Co-authored-by: Marc Duiker <[email protected]>
Signed-off-by: salaboy <[email protected]>
@salaboy @marcduiker
Update tutorials/workflow/java/external-system-interactions/src/main/…
2d00335 
…java/io/dapr/springboot/examples/external/activities/RequestApprovalActivity.java

Co-authored-by: Marc Duiker <[email protected]>
Signed-off-by: salaboy <[email protected]>
@salaboy
fixing comments
4cc708b 
Signed-off-by: salaboy <[email protected]>
@salaboy
removing old comments
0335c58 
Signed-off-by: salaboy <[email protected]>
@salaboy @marcduiker
Update tutorials/workflow/java/child-workflows/childworkflows
4a75abd 
Co-authored-by: Marc Duiker <[email protected]>
Signed-off-by: salaboy <[email protected]>
@cicoyle @salaboy
update java to latest rc
d88a528 
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: salaboy <[email protected]>
@cicoyle @salaboy
update springboot + wf
2e2a30b 
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: salaboy <[email protected]>
@cicoyle @salaboy
try 1.14.1
cf64728 
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: salaboy <[email protected]>
@siri-varma @salaboy
Update job-service.go
9142782 
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: salaboy <[email protected]>
@siri-varma @salaboy
Fix workflow
0fb77a5 
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: salaboy <[email protected]>
@salaboy
update to version 0.15.0
34f0e26 
Signed-off-by: salaboy <[email protected]>
@salaboy @marcduiker
Update tutorials/workflow/java/challenges-tips/VersioningWorkflow.java
c02c8ff 
Co-authored-by: Marc Duiker <[email protected]>
Signed-off-by: salaboy <[email protected]>
@salaboy
fixing small issues and updating to 1.15.0
f86ecde 
Signed-off-by: salaboy <[email protected]>
@siri-varma @salaboy
Update job-service.go
d313a6e 
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: salaboy <[email protected]>
@siri-varma @salaboy
Fix workflow
f56da43 
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: salaboy <[email protected]>
@salaboy
adding http extension
364a794 
Signed-off-by: salaboy <[email protected]>
@salaboy salaboy force-pushed the 1194-addind-java-tutorial branch from 4020f57 to 364a794 Compare August 18, 2025 11:15
@salaboy salaboy dismissed marcduiker’s stale review August 18, 2025 11:42

The merge-base changed after approval.

marcduiker
marcduiker previously approved these changes Aug 18, 2025
View reviewed changes
alicejgibbons
alicejgibbons approved these changes Aug 21, 2025
View reviewed changes
Copy link
Contributor

@alicejgibbons alicejgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the additional checks @marcduiker

@alicejgibbons alicejgibbons merged commit fe262ba into dapr:master Aug 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alicejgibbons alicejgibbons alicejgibbons approved these changes

@marcduiker marcduiker marcduiker left review comments

Assignees
No one assigned
Labels
do-not-merge Do not merge the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding Java Tutorials for Workflows
6 participants
@salaboy @alicejgibbons @marcduiker @cicoyle @siri-varma @svegiraju-microsoft