Skip to content

Fix(html): Handle <br> elements to insert line breaks in text #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix(html): Handle <br> elements to insert line breaks in text #1950

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
90fea07
Implement handling of <br> elements in DOM parsing to insert line bre…
Dhruv-Maradiya Dec 25, 2024
b6126c1
update tests to handle <br> elements for line breaks
Dhruv-Maradiya Dec 25, 2024
9beee02
update changelog to include fix for <br> newline handling
Dhruv-Maradiya Dec 25, 2024
2b721ea
bump version to 0.15.5+1 in html package
Dhruv-Maradiya Dec 30, 2024
aafc3f9
feat: add spec-compliant textContent with BR conversion flag
Dhruv-Maradiya Oct 19, 2025
5a001ab
Merge branch 'main' into main
Dhruv-Maradiya Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkgs/html/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.15.5+1

- Fix a bug in DOM parsing where `<br>` tags does not create a new line when html is converted to text.

## 0.15.5

- Require Dart `3.2`.
Expand Down
9 changes: 8 additions & 1 deletion pkgs/html/lib/dom_parsing.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,14 @@ class TreeVisitor {
void visitText(Text node) => visitNodeFallback(node);

// TODO(jmesserly): visit attributes.
void visitElement(Element node) => visitNodeFallback(node);
void visitElement(Element node) {
if (node.localName == 'br') {
visitText(Text('\n'));
return;
}

visitNodeFallback(node);
}

void visitComment(Comment node) => visitNodeFallback(node);

Expand Down
2 changes: 1 addition & 1 deletion pkgs/html/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: html
version: 0.15.5
version: 0.15.5+1
description: APIs for parsing and manipulating HTML content outside the browser.
repository: https://github.com/dart-lang/tools/tree/main/pkgs/html
issue_tracker: https://github.com/dart-lang/tools/issues?q=is%3Aissue+is%3Aopen+label%3Apackage%3Ahtml
Expand Down
8 changes: 4 additions & 4 deletions pkgs/html/test/parser_feature_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,11 +265,11 @@ On line 4, column 3 of ParseError: Unexpected DOCTYPE. Ignored.
});

test('Element.text', () {
final doc = parseFragment('<div>foo<div>bar</div>baz</div>');
final doc = parseFragment('<div>foo<div><br>bar</div>baz<br></div>');
final e = doc.firstChild!;
final text = e.firstChild!;
expect((text as Text).data, 'foo');
expect(e.text, 'foobarbaz');
expect(e.text, 'foo\nbarbaz\n');

e.text = 'FOO';
expect(e.nodes.length, 1);
Expand All @@ -279,15 +279,15 @@ On line 4, column 3 of ParseError: Unexpected DOCTYPE. Ignored.
});

test('Text.text', () {
final doc = parseFragment('<div>foo<div>bar</div>baz</div>');
final doc = parseFragment('<div>foo<div>bar</div><br>baz</div>');
final e = doc.firstChild!;
final text = e.firstChild as Text;
expect(text.data, 'foo');
expect(text.text, 'foo');

text.text = 'FOO';
expect(text.data, 'FOO');
expect(e.text, 'FOObarbaz');
expect(e.text, 'FOObar\nbaz');
expect(text.text, 'FOO');
});

Expand Down
Loading