Skip to content

Conversation

@hdashnow
Copy link
Member

Description

Summarize the changes

Fixes: # Link to any relevant issues and/or discussions

Major Changes

  • New locus or major change to existing locus e.g. pathogenic threshold, coordinate
  • New feature
  • New data field

Minor Changes

  • Minor change to existing locus e.g. new citation
  • Bug or gramatical error fix

Checklist

  • All changes are well summarized
  • Check all tests pass
  • Check that the website preview looks good
  • Update the STRchive version in CITATION.cff, format X.Y.Z. If any major changes, increment Y. If only minor changes, increment Z. If the breaking change (rare), increment X.
  • Ask someone to review this PR

@netlify
Copy link

netlify bot commented Oct 30, 2025

Deploy Preview for strchive ready!

Name Link
🔨 Latest commit 243a31c
🔍 Latest deploy log https://app.netlify.com/projects/strchive/deploys/693c5513aa9150000814ee2c
😎 Deploy Preview https://deploy-preview-287--strchive.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@vincerubinetti
Copy link
Contributor

vincerubinetti commented Dec 12, 2025

Okay I've implemented what I think is a good starting point for the evidence form:

  • get to the form via the "suggest evidence" button on a locus page
  • enter metadata just like the edit form (your name, github, title, desc, etc)
  • the calc field:
    • calculates the value of the field based on the value of other fields, but only when those other fields change (so you can still edit the field itself manually; it's not locked to the calculation)
    • i used the expr-eval javascript library to evaluate the calc expression, so see its docs for what syntaxes are supported
    • to reference another field in the calc, use a relative json pointer surrounded with curly braces, e.g. {sibling_field} or {../uncle_field/cousin_field}
  • demonstrates how to name and structure the json schema with if/then statements
  • shows some summary stats right above the submit button. for now, just point totals.
  • set up to add an entry to the top level list of STRtr-kit.evidence.json and create a PR

Do look closely at the diff, because I've made some changes to the edit form as well, to make it consistent with and distinct from the evidence form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants