Skip to content

ENH: torch: allow negative indices in take and take_along_axis #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ENH: torch: allow negative indices in take and take_along_axis #361

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a60869a
ENH: torch: allow negative indices in take_along_axis
ev-br Nov 22, 2025
92662a6
ENH: torch: allow negative indices in take()
ev-br Nov 22, 2025
4355ab8
MAINT: link to pytorch issue for negative indices
ev-br Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions array_api_compat/torch/_aliases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,11 +815,20 @@ def take(x: Array, indices: Array, /, *, axis: int | None = None, **kwargs: obje
if x.ndim != 1:
raise ValueError("axis must be specified when ndim > 1")
axis = 0
return torch.index_select(x, axis, indices, **kwargs)
return torch.index_select(
x,
axis,
torch.where(indices < 0, indices + x.shape[axis], indices),
**kwargs
)


def take_along_axis(x: Array, indices: Array, /, *, axis: int = -1) -> Array:
return torch.take_along_dim(x, indices, dim=axis)
return torch.take_along_dim(
x,
torch.where(indices < 0, indices + x.shape[axis], indices),
dim=axis
)


def sign(x: Array, /) -> Array:
Expand Down
Loading