-
Notifications
You must be signed in to change notification settings - Fork 799
refactor(query): migrate physical plan from enum to trait-based architecture #18268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zhang2014
wants to merge
51
commits into
databendlabs:main
Choose a base branch
from
zhang2014:refactor/physical_plan_trait
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor(query): migrate physical plan from enum to trait-based architecture #18268
zhang2014
wants to merge
51
commits into
databendlabs:main
from
zhang2014:refactor/physical_plan_trait
+15,527
−11,039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forsaken628
reviewed
Jul 15, 2025
…refactor/physical_plan_trait # Conflicts: # src/query/service/src/interpreters/interpreter_copy_into_table.rs # src/query/service/src/pipelines/builders/builder_copy_into_location.rs # src/query/service/src/pipelines/builders/builder_join.rs # src/query/service/src/pipelines/processors/transforms/transform_recursive_cte_source.rs # src/query/sql/src/executor/format.rs # src/query/sql/src/executor/physical_plans/physical_union_all.rs
…refactor/physical_plan_trait # Conflicts: # src/query/service/src/interpreters/interpreter_table_analyze.rs # src/query/service/src/physical_plans/physical_limit.rs # src/query/service/src/physical_plans/physical_recluster.rs # src/query/service/src/physical_plans/physical_table_scan.rs # src/query/service/src/pipelines/builders/builder_aggregate.rs # src/query/service/src/pipelines/builders/builder_commit.rs # src/query/service/src/pipelines/builders/builder_compact.rs # src/query/service/src/pipelines/builders/builder_hilbert_partition.rs # src/query/service/src/pipelines/builders/builder_row_fetch.rs # src/query/service/src/pipelines/builders/builder_sort.rs # src/query/service/src/pipelines/builders/builder_union_all.rs # src/query/service/src/pipelines/builders/builder_window.rs # src/query/service/src/pipelines/builders/mod.rs # src/query/service/src/pipelines/pipeline_builder.rs # src/query/service/src/pipelines/processors/transforms/transform_recursive_cte_source.rs # src/query/service/src/schedulers/fragments/fragmenter.rs # src/query/sql/src/executor/format.rs # src/query/sql/src/executor/physical_plan.rs # src/query/sql/src/executor/physical_plan_visitor.rs # src/query/sql/src/executor/physical_plans/mod.rs # src/query/sql/src/executor/physical_plans/physical_aggregate_partial.rs # src/query/sql/src/executor/physical_plans/physical_sort.rs # src/query/sql/src/executor/physical_plans/physical_union_all.rs # src/query/sql/src/executor/physical_plans/physical_window_partition.rs # src/query/sql/src/planner/optimizer/optimizers/hyper_dp/dynamic_sample/dynamic_sample.rs
Docker Image for PR
|
11 tasks
Docker Image for PR
|
Docker Image for PR
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci-benchmark
Benchmark: run all test
ci-cloud
Build docker image for cloud test
pr-refactor
this PR changes the code base without new features or bugfix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
This PR introduces a major architectural refactoring of Databend's physical plan system, migrating from a monolithic enum-based design to a modern trait-based architecture. This change significantly improves
code maintainability, performance, and extensibility while laying the foundation for future query engine enhancements.
Key Changes
Core Architecture Migration
Trait System Design
Benefits
Tests
Type of change
This change is