Skip to content

refactor: polish session in HTTP handler #18527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2025

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Aug 13, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. ignore X-DATABEND-SESSION if not enabled in caps
  2. http client in sql logic test use cookie instead of X-DATABEND-SESSION
  3. not check session id in state_handler

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@youngsofun youngsofun marked this pull request as draft August 13, 2025 14:39
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Aug 13, 2025
@youngsofun youngsofun changed the title refactor: polish HTTP session refactor: polish session in HTTP handler Aug 13, 2025
@youngsofun youngsofun marked this pull request as ready for review August 13, 2025 15:25
@youngsofun youngsofun requested a review from hantmac August 13, 2025 15:26
@youngsofun youngsofun merged commit fe3f6c6 into databendlabs:main Aug 14, 2025
96 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants