[Internal] Add integration tests for Jobs API #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoc-db
force-pushed
the
jobs-api-integration-tests
branch
from
0ee0e42 to
af7f3cf
Compare
dvkuznietsov
approved these changes
Jul 30, 2024
ricardoc-db
force-pushed
the
jobs-api-integration-tests
branch
from
af7f3cf to
8523a9e
Compare
renaudhartert-db
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Approved.
Context: As we discussed, we're moving to a new framework to handle integration tests. However, given that (i) this framework is not ready, (ii) that you've taken the time to write these tests, and (iii) that they are very minimalist, I think it is better to proceed with this PR and adapt the test later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add integration tests for Jobs API.
Note that these aren't very high-value tests at the moment, as they provide little assurances other than asserting the operations reach a valid endpoint and no unexpected exceptions are thrown.
In the future, we may want to add more thorough tests.
Tests
The tests are the change.