Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEXT_CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

### Bug Fixes

- Fixed local directory listing to include folders as well as files. Directory paths now end with '/' and are correctly marked as directories.

### Documentation

### Internal Changes
Expand Down
24 changes: 16 additions & 8 deletions databricks/sdk/mixins/files.py
Original file line number Diff line number Diff line change
Expand Up @@ -404,16 +404,24 @@ def list(self, recursive=False) -> Generator[files.FileInfo, None, None]:
path = queue.popleft()
for leaf in path.iterdir():
if leaf.is_dir():
# Yield directory info, path ends with '/'
info = leaf.stat()
yield files.FileInfo(
path="file:" + str(leaf.absolute()) + "/",
is_dir=True,
file_size=0,
modification_time=int(info.st_mtime_ns / 1e6),
)
if recursive:
queue.append(leaf)
continue
info = leaf.stat()
yield files.FileInfo(
path="file:" + str(leaf.absolute()),
is_dir=False,
file_size=info.st_size,
modification_time=int(info.st_mtime_ns / 1e6),
)
else:
info = leaf.stat()
yield files.FileInfo(
path="file:" + str(leaf.absolute()),
is_dir=False,
file_size=info.st_size,
modification_time=int(info.st_mtime_ns / 1e6),
)

def delete(self, *, recursive=False):
if self.is_dir:
Expand Down