-
Notifications
You must be signed in to change notification settings - Fork 168
initial update #1058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
initial update #1058
Conversation
Please ensure that the NEXT_CHANGELOG.md file is updated with any relevant changes. |
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
account_id: Optional[str] = None | ||
"""Databricks account ID.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a breaking change, as types are just hints in Python.
|
||
|
||
@dataclass | ||
class DeleteAliasResponse: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused Empty Response
"""Serializes the ComplianceSecurityProfile into a dictionary suitable for use as a JSON request body.""" | ||
body = {} | ||
if self.compliance_standards: | ||
body["compliance_standards"] = [v.as_dict() for v in self.compliance_standards] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bug fix that happened because of switching, as this variable is not a struct and is an enum.
|
||
self._api.do("DELETE", f"/api/2.0/preview/sql/visualizations/{id}", headers=headers) | ||
|
||
def update( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked that this API has not been used through the Python SDK in the last 3 months.
🥞 Stacked PR
Use this link to review incremental changes.
What changes are proposed in this pull request?
Provide the readers and reviewers with the information they need to understand
this PR in a comprehensive manner.
Specifically, try to answer the two following questions:
major changes to allow the reader to quickly understand the PR without having
to look at the code.
reader might be missing. For example, were there any decisions behind the
change that are not reflected in the code itself?
The “why part” is the most important of the two as it usually cannot be
inferred from the code itself. A well-written PR description will help future
developers (including your future self) to know how to interact and update your
code.
How is this tested?
Describe any tests you have done; especially if test tests are not part of
the unit tests (e.g. local tests).
ALWAYS ANSWER THIS QUESTION: Answer with "N/A" if tests are not applicable
to your PR (e.g. if the PR only modifies comments). Do not be afraid of
answering "Not tested" if the PR has not been tested. Being clear about what
has been done and not done provides important context to the reviewers.