remove previous url system #695
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThibaudDauce
force-pushed
the
remove_previous_url_system
branch
from
bd98e7b to
7483381
Compare
ThibaudDauce
requested review from
maudetes and
nicolaskempf57
and removed request for
maudetes
8 tasks
ThibaudDauce
added a commit
to opendatateam/udata
that referenced
this pull request
Jul 8, 2025
Requires datagouv/udata-front#695 - [x] Remove `endpoint_for()` calls - [x] Remove `fields.UrlFor()` - [x] Remove `display_url` - [x] Remove `external_url` and `external_url_with_campaign` - [x] ~~Remove territories?~~ (in another PR) - [x] Default to `_external=True` everywhere - [x] Flash messages? - [x] ~~Add back fallback for `x.page` in API response?~~ Regexp search in VSCode: `url_for\(\s*["'](?!(api))[^"]*['"]`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.