-
Notifications
You must be signed in to change notification settings - Fork 22
Limit batch interface to 100 items in UI and 10,000 via API #1213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fe7f037
to
1c82387
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1213 +/- ##
==========================================
- Coverage 71.73% 71.73% -0.01%
==========================================
Files 66 66
Lines 4479 4482 +3
==========================================
+ Hits 3213 3215 +2
- Misses 1266 1267 +1
🚀 New features to boost your workflow:
|
datalab
|
Project |
datalab
|
Branch Review |
bc/limit-batch
|
Run status |
|
Run duration | 08m 00s |
Commit |
|
Committer | Ben Charmes |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
504
|
View all changes introduced in this branch ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for having a go at this @BenjaminCharmes!
I think the overall problem is more that once you type in 1000, the UI makes 1000 rows which is mega slow, so we need the validation to happen before that step (apologies if this code does indeed do that, I can't test locally right now). I think due to the way we're binding the value from the input
, it ignores the already set max
, so it might just be a case of preventing the rows from being rendered until the number in the box is valid.
Yes, that's right — with this PR, it works as expected: the UI doesn't allow rendering more than 100 rows. So even if you type in a higher number like 1000, it won't actually render more than 100 rows, display an error message and disable Submit button. |
Re-add style
Co-authored-by: Matthew Evans <[email protected]>
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, thanks @BenjaminCharmes!
Closes #1070
window.alert() will be replaced with new composant from #1212