Added the option to read multiple echem files and stitch them together to the cycleBlock #1307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1307 +/- ##
==========================================
- Coverage 80.15% 80.07% -0.09%
==========================================
Files 70 70
Lines 4707 4727 +20
==========================================
+ Hits 3773 3785 +12
- Misses 934 942 +8
🚀 New features to boost your workflow:
|
be-smith
requested review from
jdbocarsly,
ml-evs and
BenjaminCharmes
as code owners
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
bes/echem_multi_file
|
| Run status |
|
| Run duration | 07m 09s |
| Commit |
|
| Committer | Ben Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
336
|
| View all changes introduced in this branch ↗︎ | |
ml-evs
reviewed
Aug 8, 2025
There was a problem hiding this comment.
Great work @be-smith! Some comments from our discussion:
- Let's choose
file_idsas the ground truth, and let the block decide whether to do multi or not itself, i.e., remove all the multi_select_flag stuff from the Python side. - Forget about caching multifile stuff for now, given caveats around underlying updating (hopefully this just removing code)
- UI side: think about populating
selected fileswith some default sort mechanism of all available files by default - Probably the above point would need to switch to "Apply" button style rather dynamic
Final stretch goaly kinda thing:
People will want to use this to compare cells, we should probably let them even if its a bit inelegant for now -- eventually this code could be moved to a separate app if lots of extra controls are needed.
|
A reminder for when we discuss changes - do we want prev_file_ids to persist across reloads etc - for switching between the plotting modes or do we not care? |
be-smith
force-pushed
the
bes/echem_multi_file
branch
2 times, most recently
from
6497d25 to
df12fd0
Compare
ml-evs
reviewed
Aug 22, 2025
…ed file_id and decide beahviour based on length of list
…dd all button to move them all over
… switching between modes. Changed when the bokeh block is rendered so the plot doesn't dissapear and reappear when messing with the file list
…ore consistent with echem block for using multiple files
… and added a logger
Co-authored-by: Matthew Evans <[email protected]>
be-smith
force-pushed
the
bes/echem_multi_file
branch
from
d3b38e5 to
8ed26e5
Compare
ml-evs
reviewed
Aug 28, 2025
- Fix case of single file ID passed to echem block
ml-evs
force-pushed
the
bes/echem_multi_file
branch
from
d84db65 to
c846c8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilising new Navani functionality to read and stitch together multiple echem files.
Shouldn't change functionality of existing blocks as doesn't change single file behaviour - adds a button to toggle between the single file reader and the multi file reader.
