-
Notifications
You must be signed in to change notification settings - Fork 23
[WIP] Add Mermaid support to Quill #1345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add QuillJS to package.json Add QuillJS to package.json Add data-testid to EditorTransition.vue for cypress Add data-testid to EditorTransition.vue for cypress Add data-testid to EditorTransition.vue for cypress Add data-testid to EditorTransition.vue for cypress Add data-testid to EditorTransition.vue for cypress Add data-testid to EditorTransition.vue for cypress
Thanks @BenjaminCharmes, this superseded by #1349 where we chose TipTap! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional work from issue #1232 and PR #1343
Already works nicely, but we need to store
description
in Delta format inside the database to make Mermaid work in QuillJS. Could be improved further if needed.Some issues between Quill 2 and quill-mermaid (which seems to have been made for Quill 1), but difficult to find another library that works with Quill 2, need to spend more time on this issue.