Skip to content

Conversation

BenjaminCharmes
Copy link
Contributor

@BenjaminCharmes BenjaminCharmes commented Sep 12, 2025

Additional work from issue #1232 and PR #1343

Already works nicely, but we need to store description in Delta format inside the database to make Mermaid work in QuillJS. Could be improved further if needed.

Some issues between Quill 2 and quill-mermaid (which seems to have been made for Quill 1), but difficult to find another library that works with Quill 2, need to spend more time on this issue.

Add QuillJS to package.json

Add QuillJS to package.json

Add data-testid to EditorTransition.vue for cypress

Add data-testid to EditorTransition.vue for cypress

Add data-testid to EditorTransition.vue for cypress

Add data-testid to EditorTransition.vue for cypress

Add data-testid to EditorTransition.vue for cypress

Add data-testid to EditorTransition.vue for cypress
@cypress
Copy link

cypress bot commented Sep 12, 2025

datalab    Run #3861

Run Properties:  status check failed Failed #3861  •  git commit b6f53f0574 ℹ️: Merge b487ebe3cace472ebb88c22448c05b724571425d into 986d3b3153b58a952cd2ecd7bfe3...
Project datalab
Branch Review bc/quill-mermaid
Run status status check failed Failed #3861
Run duration 05m 15s
Commit git commit b6f53f0574 ℹ️: Merge b487ebe3cace472ebb88c22448c05b724571425d into 986d3b3153b58a952cd2ecd7bfe3...
Committer Ben Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 22
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 78
View all changes introduced in this branch ↗︎

Tests for review

Failed  batchSampleFeature.cy.js • 6 failed tests • End-to-end tests (electron)

View Output

Test Artifacts
Batch sample creation > modifies some data in the first sample Test Replay Screenshots
Batch sample creation > modifies some data in the second sample Test Replay Screenshots
Batch sample creation > checks the copied samples Test Replay Screenshots
Batch sample creation > checks the created samples Test Replay Screenshots
Batch sample creation > uses the template id, name, date, copyFrom, and components Test Replay Screenshots
Batch sample creation > plays with the number of rows Test Replay Screenshots
Failed  editPage.cy.js • 1 failed test • End-to-end tests (electron)

View Output

Test Artifacts
Edit Page > Add some blocks to the sample and checks unsaved warning behavior Test Replay Screenshots
Failed  equipment.cy.js • 1 failed test • End-to-end tests (electron)

View Output

Test Artifacts
Equipment edit page > modifies some data in a sample Test Replay Screenshots
Failed  sampleTablePage.cy.js • 3 failed tests • End-to-end tests (electron)

View Output

Test Artifacts
Advanced sample creation features > modifies some data in the second sample Test Replay Screenshots
Advanced sample creation features > checks the edit page of the copied sample Test Replay Screenshots
Advanced sample creation features > checks the edit page of the copied sample with components Test Replay Screenshots
Failed  batchSampleFeature.cy.js • 6 failed tests • End-to-end tests (chrome)

View Output

Test Artifacts
Batch sample creation > modifies some data in the first sample Test Replay Screenshots
Batch sample creation > modifies some data in the second sample Test Replay Screenshots
Batch sample creation > checks the copied samples Test Replay Screenshots
Batch sample creation > checks the created samples Test Replay Screenshots
Batch sample creation > uses the template id, name, date, copyFrom, and components Test Replay Screenshots
Batch sample creation > plays with the number of rows Test Replay Screenshots

The first 5 failed specs are shown, see all 8 specs in Cypress Cloud.

@BenjaminCharmes BenjaminCharmes changed the title [WIP] Add Mermaid support to Quill Add Mermaid support to Quill Sep 15, 2025
@BenjaminCharmes BenjaminCharmes changed the title Add Mermaid support to Quill [WIP] Add Mermaid support to Quill Sep 17, 2025
@ml-evs
Copy link
Member

ml-evs commented Sep 30, 2025

Thanks @BenjaminCharmes, this superseded by #1349 where we chose TipTap!

@ml-evs ml-evs closed this Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants