-
Notifications
You must be signed in to change notification settings - Fork 22
Added manager to the admin dashboard #1352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1352 +/- ##
==========================================
- Coverage 80.10% 80.02% -0.08%
==========================================
Files 70 70
Lines 4755 4807 +52
==========================================
+ Hits 3809 3847 +38
- Misses 946 960 +14
🚀 New features to boost your workflow:
|
datalab
|
Project |
datalab
|
Branch Review |
bc/admin-manager
|
Run status |
|
Run duration | 07m 41s |
Commit |
|
Committer | Ben Charmes |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
336
|
View all changes introduced in this branch ↗︎ |
0d556e1
to
65a6e6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @BenjaminCharmes, just tried it out, whilst it works quite nicely in usual cases, I seemed to be able to crash it by making user A manager of another user B, and then making that user B manager of user A, where I get "cyclic object value"
as an error.
This seems to happen at arbitrary depths too, i.e., A -> B -> C -> A manager loops.
Finally, it would be good to add some tests for this new API route, i.e., make a user another user's manager, check that they have to be a manager/admin themselves, and make sure they can see that user's items once they are their manager.
Closes #1348