Skip to content

Conversation

BenjaminCharmes
Copy link
Contributor

@BenjaminCharmes BenjaminCharmes commented Oct 3, 2025

Related to an issue in #1355

  • When an item is deleted, all relationships pointing to it are now removed
  • Prevents "nonexistent source" errors in the graph view
  • Synthesis constituents are transformed to inline substances

Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.17%. Comparing base (b121182) to head (bd0e960).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1368      +/-   ##
==========================================
+ Coverage   80.10%   80.17%   +0.07%     
==========================================
  Files          70       70              
  Lines        4755     4778      +23     
==========================================
+ Hits         3809     3831      +22     
- Misses        946      947       +1     
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/routes/v0_1/items.py 86.93% <100.00%> (+0.56%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

cypress bot commented Oct 3, 2025

datalab    Run #3923

Run Properties:  status check passed Passed #3923  •  git commit f6896714ff ℹ️: Merge bd0e960ea99f5a662629e82b89412aed14a93545 into b121182e7a2c4ca1eebd268ed0b8...
Project datalab
Branch Review bc/relationships-bug
Run status status check passed Passed #3923
Run duration 07m 06s
Commit git commit f6896714ff ℹ️: Merge bd0e960ea99f5a662629e82b89412aed14a93545 into b121182e7a2c4ca1eebd268ed0b8...
Committer Ben Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 336
View all changes introduced in this branch ↗︎

@BenjaminCharmes BenjaminCharmes changed the title clean up relationships and constituents on item deletion Fix relationship cleanup on deletion Oct 3, 2025
@BenjaminCharmes BenjaminCharmes marked this pull request as ready for review October 3, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant