Add translation of PIDINST schema to pydantic #304
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #114 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
Superseded by #531 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply adds a pydantic model for instruments that is a direct translation of the RDA PIDINST schema https://github.com/rdawg-pidinst/schema/blob/master/schema.rst.
They themselves provide two versions that includes a translation to DataCite's format. It's not clear how they expect this data to be reused.
I don't like the resource layout (it is very XML-y) so think we should use this as an example for having our own internally schema but being able to map out to others. I may offer to contribute this file back upstream to PIDINST (maybe as LinkML yaml instead) and see what they say.