Skip to content

Allow starting materials and equipment to be edited by normal users #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2024
Merged

Allow starting materials and equipment to be edited by normal users #672

merged 2 commits into from
Apr 3, 2024

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Mar 27, 2024 •
edited
Loading

Closes #671.

@ml-evs ml-evs force-pushed the ml-evs/fix-perms branch from 4f7d211 to 4e88ba0 Compare March 27, 2024 21:32
@cypress Cypress
Copy link

cypress bot commented Mar 27, 2024 •
edited
Loading

Passing run #1433 ↗︎

0 40 0 0 Flakiness 0

Details:

Merge ecfda44 into 7cd96c4...
Project: datalab Commit: 5df3ffc129 ℹ️
Status: Passed Duration: 02:04 💡
Started: Apr 3, 2024 5:09 PM Ended: Apr 3, 2024 5:11 PM

Review all test suite changes for PR #672 ↗︎

@ml-evs ml-evs mentioned this pull request Mar 28, 2024
Closed
14 tasks
@ml-evs ml-evs force-pushed the ml-evs/fix-perms branch from 4e88ba0 to 1246a07 Compare April 3, 2024 15:36
@ml-evs ml-evs marked this pull request as ready for review April 3, 2024 15:36
@ml-evs ml-evs requested a review from jdbocarsly April 3, 2024 15:37
@ml-evs ml-evs enabled auto-merge (squash) April 3, 2024 15:38
@codecov Codecov
Copy link

codecov bot commented Apr 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.56%. Comparing base (7cd96c4) to head (ecfda44).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #672   +/-   ##
=======================================
  Coverage   66.55%   66.56%           
=======================================
  Files          61       61           
  Lines        3600     3601    +1     
=======================================
+ Hits         2396     2397    +1     
  Misses       1204     1204
Files Coverage Δ
pydatalab/pydatalab/routes/v0_1/items.py 81.53% <100.00%> (+0.07%) ⬆️

@ml-evs ml-evs disabled auto-merge April 3, 2024 17:00
@ml-evs ml-evs force-pushed the ml-evs/fix-perms branch from 1246a07 to ecfda44 Compare April 3, 2024 17:00
@ml-evs ml-evs merged commit 3bb467f into main Apr 3, 2024
@ml-evs ml-evs deleted the ml-evs/fix-perms branch April 3, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdbocarsly jdbocarsly Awaiting requested review from jdbocarsly jdbocarsly is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Users can't edit starting materials and equipment

1 participant

@ml-evs