Skip to content

Fix Set-DbaAgentJobStep: Add proxy removal support and prevent unwanted parameter resets #9861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Fix Set-DbaAgentJobStep: Add proxy removal support and prevent unwanted parameter resets #9861

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5d52d1
Fix Set-DbaAgentJobStep parameter handling for ProxyName, RetryAttemp…
SylvainDuran Oct 14, 2025
84b3c7e
Use Test-Bound instead of PSBoundParameters.ContainsKey for parameter…
SylvainDuran Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions public/Set-DbaAgentJobStep.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,12 +343,12 @@ function Set-DbaAgentJobStep {
}
}

if ($null -ne $RetryAttempts) {
if (Test-Bound -ParameterName 'RetryAttempts') {
Write-Message -Message "Setting job step retry attempts to $RetryAttempts" -Level Verbose
$jobStep.RetryAttempts = $RetryAttempts
}

if ($null -ne $RetryInterval) {
if (Test-Bound -ParameterName 'RetryInterval') {
Write-Message -Message "Setting job step retry interval to $RetryInterval" -Level Verbose
$jobStep.RetryInterval = $RetryInterval
}
Expand All @@ -358,9 +358,13 @@ function Set-DbaAgentJobStep {
$jobStep.OutputFileName = $OutputFileName
}

if ($ProxyName) {
# Check if the proxy exists
if ($Server.JobServer.ProxyAccounts.Name -contains $ProxyName) {
if (Test-Bound -ParameterName 'ProxyName') {
if ([string]::IsNullOrEmpty($ProxyName)) {
# Remove proxy from job step
Write-Message -Message "Removing proxy from job step" -Level Verbose
$jobStep.ProxyName = ''
} elseif ($Server.JobServer.ProxyAccounts.Name -contains $ProxyName) {
# Set or update proxy name
Write-Message -Message "Setting job step proxy name to $ProxyName" -Level Verbose
$jobStep.ProxyName = $ProxyName
} else {
Expand Down