[RAPTOR-13896] force reconciling deps for all the envs except genai-agents #1523
Conversation
yakov-g
changed the title
engprod-2
bot
changed the title
|
The Needs Review labels were added based on the following file changes. Team @datarobot/buzok (#buzok) was assigned because of changes in files:public_dropin_environments/python311_genai/env_info.json public_dropin_environments/python311_genai/requirements.txt Team @datarobot/core-modeling (#predictive-ai) was assigned because of changes in files:public_dropin_environments/python3_keras/env_info.json public_dropin_environments/python3_keras/requirements.txt public_dropin_environments/python3_pmml/env_info.json public_dropin_environments/python3_pmml/requirements.txt public_dropin_environments/python3_pytorch/env_info.json public_dropin_environments/python3_pytorch/requirements.txt public_dropin_environments/python3_sklearn/env_info.json public_dropin_environments/python3_sklearn/requirements.txt public_dropin_environments/python3_xgboost/env_info.json public_dropin_environments/python3_xgboost/requirements.txt public_dropin_environments/r_lang/env_info.json public_dropin_environments/r_lang/requirements.txt Team @datarobot/genai-systems (#genai-systems) was assigned because of changes in files:public_dropin_environments/java_codegen/env_info.json public_dropin_environments/java_codegen/requirements.txt public_dropin_environments/python311/env_info.json public_dropin_environments/python311/requirements.txt public_dropin_environments/python3_keras/env_info.json public_dropin_environments/python3_keras/requirements.txt public_dropin_environments/python3_onnx/env_info.json public_dropin_environments/python3_onnx/requirements.txt public_dropin_environments/python3_pmml/env_info.json public_dropin_environments/python3_pmml/requirements.txt public_dropin_environments/python3_pytorch/env_info.json public_dropin_environments/python3_pytorch/requirements.txt public_dropin_environments/python3_sklearn/env_info.json public_dropin_environments/python3_sklearn/requirements.txt public_dropin_environments/python3_xgboost/env_info.json public_dropin_environments/python3_xgboost/requirements.txt public_dropin_environments/r_lang/env_info.json public_dropin_environments/r_lang/requirements.txt public_dropin_gpu_environments/vllm/env_info.json public_dropin_gpu_environments/vllm/requirements.txt If you think that there are some issues with ownership, please discuss with C&A domain at #sdtk slack channel and create PR to update DRCODEOWNERS\CODEOWNERS file. |
yakov-g
force-pushed
the
yakov/bump-all-deps
branch
from
cdd5ac9 to
1bbd934
Compare
yakov-g
force-pushed
the
yakov/bump-all-deps
branch
from
c0b0b1f to
9219fd7
Compare
There was a problem hiding this comment.
Generally LGTM for Predictive AI.
I also reviewed a PR from dependabot, bumping just protobuf in just the xgboost drop-in environment. That PR #1521 would conflict with this one -- but yours is essentially a superset of that one. Just FYI -- if you can get this green and merged before that one goes in, I think that's OK.
| datarobot==3.7.1 | ||
| datarobot-drum==1.16.17 | ||
| datarobot-mlops==11.1.0a3 | ||
| datarobot-mlops==11.0.0 |
There was a problem hiding this comment.
This seems to be a downgrade, 11.1 to 11.0 -- is that intentional?
There was a problem hiding this comment.
Looks like pip-compile always take the latest released version, ignoring pre-releases.
Pinning it in the requirements.in
There was a problem hiding this comment.
Oh, I see, it was a pre-release. I could see it either way, then. Do you know, is the stable release 11.1 of datarobot-mlops coming soon?
There was a problem hiding this comment.
I'm trying to figure out, but no luck yet
yakov-g
force-pushed
the
yakov/bump-all-deps
branch
4 times, most recently
from
f9de842 to
ca1031f
Compare
yakov-g
force-pushed
the
yakov/bump-all-deps
branch
2 times, most recently
from
79f65db to
e1b2f9f
Compare
yakov-g
force-pushed
the
yakov/bump-all-deps
branch
from
af790a1 to
b7e3425
Compare
|
Overall I'm not sure the intention of bumping everything to latest is good when signoffs and testing are getting to the end. Such a move is probably good but earlier in the cycle. |
Yeah, I tried to do it earlier. But more important tasks hopped in. |
This repository is public. Do not put here any private DataRobot or customer's data: code, datasets, model artifacts, .etc.
Summary
Force reconciling deps for all the envs except genai-agents.
I think worth doing before release/
Rationale