Skip to content

CNDB-14359: Add tracking of dropped mutations by table #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2025
Merged

CNDB-14359: Add tracking of dropped mutations by table #1790

merged 2 commits into from
Oct 24, 2025

Conversation

@driftx
Copy link

@driftx driftx commented Jun 4, 2025

What is the issue

Fixes #14359

@github-actions
Copy link

github-actions bot commented Jun 4, 2025

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
24.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@driftx driftx requested a review from a team June 5, 2025 11:53
@driftx driftx removed the request for review from a team October 20, 2025 17:41
@niksajakovljevic niksajakovljevic requested review from a team and niksajakovljevic October 22, 2025 09:55
@michaelsembwever michaelsembwever changed the title Add tracking of dropped mutations by table CNDB-14359: Add tracking of dropped mutations by table Oct 22, 2025
niksajakovljevic
niksajakovljevic reviewed Oct 22, 2025
View reviewed changes
niksajakovljevic
niksajakovljevic approved these changes Oct 22, 2025
View reviewed changes
Copy link
Collaborator

@niksajakovljevic niksajakovljevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left one nit comment about API weirdness.

@niksajakovljevic niksajakovljevic self-requested a review October 22, 2025 10:20
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 24, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cassci-bot
Copy link

cassci-bot commented Oct 24, 2025

❌ Build ds-cassandra-pr-gate/PR-1790 rejected by Butler

1 regressions found
See build details here

Found 1 new test failures

Test Explanation Runs Upstream
o.a.c.utils.binlog.BinLogTest.testTruncationReleasesLogSpace (compression) REGRESSION 🔵🔴 0 / 12

No known test failures found

@driftx driftx merged commit d9f7fe9 into main Oct 24, 2025
493 of 494 checks passed
@driftx driftx deleted the CNDB-14359 branch October 24, 2025 19:53
michaelsembwever pushed a commit that referenced this pull request Nov 3, 2025
@driftx @michaelsembwever
CNDB-15826: CNDB-14359: Add tracking of dropped mutations by table (#…
ea6091c 
…1790)

Fixes #14359
michaelsembwever pushed a commit that referenced this pull request Nov 13, 2025
@driftx @michaelsembwever
CNDB-15826: CNDB-14359: Add tracking of dropped mutations by table (#…
127d191 
…1790)

Fixes #14359
michaelsembwever pushed a commit that referenced this pull request Nov 13, 2025
@driftx @michaelsembwever
CNDB-15826: CNDB-14359: Add tracking of dropped mutations by table (#…
5ef3df1 
…1790)

Fixes #14359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelsembwever michaelsembwever michaelsembwever approved these changes

@niksajakovljevic niksajakovljevic niksajakovljevic approved these changes

Assignees

No one assigned

Labels

core-team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@driftx @cassci-bot @michaelsembwever @niksajakovljevic