Skip to content

Conversation

driftx
Copy link

@driftx driftx commented Sep 15, 2025

What is the issue

Invalid guardrails values can be caught sooner with a test.

What does this PR fix and why was it fixed

Fixes #15363 by adding a test that default guardrail values are correctly set for HCD, DBAaS, and NoProfile configurations via applyConfig and enforceDefault.

Copy link

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

Copy link

@cassci-bot
Copy link

✔️ Build ds-cassandra-pr-gate/PR-1999 approved by Butler


Approved by Butler
See build details here

@driftx driftx requested a review from djatnieks September 15, 2025 14:08
Copy link

@djatnieks djatnieks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@driftx driftx merged commit 778a99a into main Sep 15, 2025
492 checks passed
@driftx driftx deleted the CNDB-15363 branch September 15, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants